From: Hungyu Lin <dennylin0707@gmail.com>
To: thierry.reding@gmail.com, jonathanh@nvidia.com,
skomatineni@nvidia.com, luca.ceresoli@bootlin.com
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Hungyu Lin <dennylin0707@gmail.com>
Subject: [PATCH] media: tegra-video: tegra210: ensure PHY is disabled in pg_mode stop path
Date: Sun, 12 Apr 2026 16:36:00 +0000 [thread overview]
Message-ID: <20260412163600.29925-1-dennylin0707@gmail.com> (raw)
tegra210_csi_port_start_streaming() enables the CSI PHY regardless
of pg_mode, but tegra210_csi_port_stop_streaming() skips disabling
the PHY when pg_mode is set due to an early return.
Remove the early return so that the PHY disable path is always
executed, ensuring consistent teardown.
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/staging/media/tegra-video/tegra210.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/media/tegra-video/tegra210.c b/drivers/staging/media/tegra-video/tegra210.c
index da99f19a39e7..57b5da11da93 100644
--- a/drivers/staging/media/tegra-video/tegra210.c
+++ b/drivers/staging/media/tegra-video/tegra210.c
@@ -1095,11 +1095,9 @@ tegra210_csi_port_stop_streaming(struct tegra_csi_channel *csi_chan, u8 portno)
(0xf << CSI_PP_START_MARKER_FRAME_MAX_OFFSET) |
CSI_PP_DISABLE);
- if (csi_chan->pg_mode) {
+ if (csi_chan->pg_mode)
tpg_write(csi, portno, TEGRA_CSI_PATTERN_GENERATOR_CTRL,
PG_DISABLE);
- return;
- }
if (csi_chan->numlanes == 4) {
csi_write(csi, portno, TEGRA_CSI_PHY_CIL_COMMAND,
--
2.34.1
reply other threads:[~2026-04-12 16:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260412163600.29925-1-dennylin0707@gmail.com \
--to=dennylin0707@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mchehab@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox