Re: [PATCH v4 1/2] iio: frequency: ad9832: remove kernel.h proxy header.

Andy Shevchenko
2026-04-15T08:56:52Z

On Wed, Apr 15, 2026 at 08:08:11AM +0000, Joshua Crofts wrote:

Drop the period at the end of Subject.

> Remove kernel.h proxy header and add bitops.h for
> better dependency control and code clarity. Also
> removed slab.h and moved asm header below generic
> linux headers.

I wonder if we need to elaborate a bit on 'linux' word as usually we refer to
the project as Linux. Maybe write it as '<linux/*>' (without quotes)?

> Checked with IWYU.

We have a (recently new) tag: Assisted-by or so. Can we use it here?

Otherwise LGTM, so after addressing the above:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

--
With Best Regards,
Andy Shevchenko