Re: [PATCH 0/1] media: atomisp: mt9m114: Graceful teardown atomisp and mt9m114

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Robert,
On Sat, Apr 18, 2026 at 11:26:50AM +0200, Robert Mast wrote:
> From: Robert Mast <rmast@live.nl>
> 
> During the many iterations on mt9m114 and atomisp on my T100ta baytrail
> I was annoyed by having to reboot each time, as modprobe -r/modprobe
> wasn't able to fully reinitialize mt9m114 and atomisp, resulting in cpu
> core hang ups. I asked Github Copilot Enterprise to fix it for me, and
> the fix looks quite good and has served me well since. I'm not able to
> distinguish any structural flaw, so please review.

No, sorry. You first need to get a complete understanding of the logic
yourself before you can ask other people to review the code. This
includes cleaning up all the obvious mistakes, and turning it into a
form suitable for upstream. Dumping code isn't acceptable.

This applies to v2 as well.

> Robert Mast (1):
>   media: atomisp: mt9m114: Graceful teardown atomisp and mt9m114
> 
>  drivers/media/i2c/mt9m114.c                   | 118 ++++++++++++++++--
>  .../media/atomisp/pci/atomisp_csi2_bridge.c   |   1 +
>  .../staging/media/atomisp/pci/atomisp_v4l2.c  |   3 +
>  3 files changed, 110 insertions(+), 12 deletions(-)

-- 
Regards,

Laurent Pinchart