From: Greg KH <gregkh@linuxfoundation.org>
To: Matan Cohen <matan@matanco.space>
Cc: Dan Carpenter <error27@gmail.com>,
linux-staging@lists.linux.dev,
parthiban.veerasooran@microchip.com,
christian.gromm@microchip.com
Subject: Re: [PATCH] staging: most: video: replace BUG_ON with WARN_ON_ONCE and add recovery
Date: Tue, 21 Apr 2026 17:22:42 +0200 [thread overview]
Message-ID: <2026042135-fragile-bluff-024c@gregkh> (raw)
In-Reply-To: <eb5f1c7f-f363-49a0-9a3e-5bf8923ffca9@app.fastmail.com>
On Tue, Apr 21, 2026 at 06:15:29PM +0300, Matan Cohen wrote:
> On Mon, Apr 20, 2026, at 5:14 PM, Dan Carpenter wrote:
> > I always dread these kinds of patches... The comment is useless. Way
> > too vague and kind of wrong also. I want to see a much more thorough
> > explanation.
>
> Hi Dan and Greg's bot,
>
> First of All Thank you for the review and quick reply.
> This is my first time Contributing, I wanted to start with something well contained that I found using checkpatch.pl
>
> My intention was twofold:
>
> 1. Replace BUG_ON with WARN_ON_ONCE — the kernel should not crash
> unconditionally here since the cleanup above already completed.
Note, you have trailing whitespace in yoru email client, please fix that
up.
Anyway, you can not replace BUG_ON() with WARN_ON() and expect the crash
to go away due to panic-on-warn being an option that a few billion Linux
systems have. If this type of thing can happen, then handle it properly
and deal with it, otherwise if it is so bad that all data will be lost,
live with the BUG_ON().
thanks,
greg k-h
prev parent reply other threads:[~2026-04-21 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 11:35 [PATCH] staging: most: video: replace BUG_ON with WARN_ON_ONCE and add recovery Matan Cohen
2026-04-20 12:35 ` Greg KH
2026-04-20 14:14 ` Dan Carpenter
2026-04-21 15:15 ` Matan Cohen
2026-04-21 15:22 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026042135-fragile-bluff-024c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=christian.gromm@microchip.com \
--cc=error27@gmail.com \
--cc=linux-staging@lists.linux.dev \
--cc=matan@matanco.space \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox