From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB082373BE6; Mon, 27 Apr 2026 03:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777261835; cv=none; b=WJmnAs4F8dwbzZYs9R6Z8jRki4hVQ/XW/FZZvXAu7K2qDN9hrwM2CHpaR/mvGj/L4I68wj+u1iDSJTBQC/MyAFuiLVJRih9fBdZf7UIWJ/Chu2JRYp9OBm6+UjYb2O3r1pzoq4epGEkvZwWQcjkppgo01/pbdTqugVIaqUoeyKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777261835; c=relaxed/simple; bh=6MbnM58GaH7QWBbKVSg3Dvl46HfyaUY5rCyabLyoRyE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lZikFGQoDlDIIUdS5l1WiX92OYDr0GfRWCFVxkhlCHh5Tw0enPaqc4AVWy6hOAqmzDkYL/zxBD7g0uO4f5tr4sKiJUWh+BRYisuikD3rlfGCQVMAHSn69HN/GlHdNQSgVhHVxkG0+paSSQ/1tGRECE0F78h7RGASsVHbUt/nOjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jvjnijRw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jvjnijRw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B18E6C2BCB8; Mon, 27 Apr 2026 03:50:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777261835; bh=6MbnM58GaH7QWBbKVSg3Dvl46HfyaUY5rCyabLyoRyE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jvjnijRwFYP3owM3BzNGcNARHoWCvk9hAdrBHHwtMF4zKwILQCZzQvF817ZPFpl0p DHIBhWvTAHopgeGCxA3fKdCQ+pPx2foo19pM2M9AewGjij3O7b1hVpDI3f08gEfkmi A7Cpn/jIVqhuw5+rx3sUEXwuNqRkfckLpe7N0ZY0= Date: Sun, 26 Apr 2026 21:08:44 +0200 From: Greg Kroah-Hartman To: Hungyu Lin Cc: Sudip Mukherjee , Teddy Wang , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] staging: sm750fb: propagate error codes from de_wait() Message-ID: <2026042610-tavern-easiest-c69c@gregkh> References: <20260409155821.23375-1-dennylin0707@gmail.com> <20260409155821.23375-3-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260409155821.23375-3-dennylin0707@gmail.com> On Thu, Apr 09, 2026 at 03:58:21PM +0000, Hungyu Lin wrote: > The sm750 acceleration functions currently return -1 when > de_wait() fails, discarding the original error code. > > Since de_wait() now returns proper errno values, propagate > the error code instead of returning -1. You can use the full 72 columns for a changelog text. > > Signed-off-by: Hungyu Lin > --- > drivers/staging/sm750fb/sm750_accel.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c > index 0f94d859e91c..688ec262a8ed 100644 > --- a/drivers/staging/sm750fb/sm750_accel.c > +++ b/drivers/staging/sm750fb/sm750_accel.c > @@ -90,14 +90,16 @@ int sm750_hw_fillrect(struct lynx_accel *accel, > u32 color, u32 rop) > { > u32 de_ctrl; > + int ret; > > - if (accel->de_wait() != 0) { > + ret = accel->de_wait(); > + if (ret) { > /* > - * int time wait and always busy,seems hardware > + * int time wait and always busy, seems hardware Nice fix, but not part of this change to make :( thanks, greg k-h