public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Probert <linus.probert@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8723bs: correct logical continuation check in rtw_btcoex.c
Date: Sun, 26 Apr 2026 21:28:36 +0200	[thread overview]
Message-ID: <2026042618-headfirst-frill-2d79@gregkh> (raw)
In-Reply-To: <20260403220310.1824969-2-linus.probert@gmail.com>

On Sat, Apr 04, 2026 at 12:03:09AM +0200, Linus Probert wrote:
> Corrects logical continuation placement in rtw_btcoex.c
> Discovered and verified with checkpatch.pl
> 
> Signed-off-by: Linus Probert <linus.probert@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_btcoex.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> index 0191a943f0a4..caa757b8dc0a 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> @@ -10,8 +10,8 @@
>  
>  void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
>  {
> -	if ((media_status == RT_MEDIA_CONNECT)
> -		&& (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
> +	if (media_status == RT_MEDIA_CONNECT &&
> +	    check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true) {
>  		rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
>  	}
>  
> -- 
> 2.53.0
> 

I hate this checkpatch "warning" as you now need to remember what the
order of operations is :(

  reply	other threads:[~2026-04-27  3:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-03 22:03 [PATCH 0/2] staging: rtl8723bs: checkpatch cleanup rtw_btcoex.c Linus Probert
2026-04-03 22:03 ` [PATCH 1/2] staging: rtl8723bs: correct logical continuation check in rtw_btcoex.c Linus Probert
2026-04-26 19:28   ` Greg Kroah-Hartman [this message]
2026-04-03 22:03 ` [PATCH 2/2] staging: rtl8723bs: remove multiple blank lines " Linus Probert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026042618-headfirst-frill-2d79@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linus.probert@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox