public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: luka.gejak@linux.dev
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 03/11] staging: rtl8723bs: os_dep: fix spacing around operators
Date: Sun, 26 Apr 2026 22:04:54 +0200	[thread overview]
Message-ID: <2026042621-italics-landfall-82b9@gregkh> (raw)
In-Reply-To: <20260413101432.158925-4-luka.gejak@linux.dev>

On Mon, Apr 13, 2026 at 12:14:24PM +0200, luka.gejak@linux.dev wrote:
> From: Luka Gejak <luka.gejak@linux.dev>
> 
> Fix spaces around operators in the os_dep directory to adhere to the
> Linux kernel coding style. This resolves multiple spacing warnings
> reported by checkpatch.pl.
> 
> Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
> ---
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 +-
>  drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index d0feb28b7043..95523c3a508b 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -77,7 +77,7 @@ static int sdio_alloc_irq(struct dvobj_priv *dvobj)
>  
>  	sdio_release_host(func);
>  
> -	return err?_FAIL:_SUCCESS;
> +	return err ? _FAIL : _SUCCESS;
>  }
>  
>  static void sdio_free_irq(struct dvobj_priv *dvobj)
> diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> index f9c4d487badf..ce835802c442 100644
> --- a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> +++ b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> @@ -93,7 +93,7 @@ static int _rtw_reg_notifier_apply(struct wiphy *wiphy,
>  
>  static const struct ieee80211_regdomain *_rtw_regdomain_select(struct
>  							       rtw_regulatory
> -							       *reg)
> + * reg)

What just happened?  How was this generated?  What tool did you use?

And this series is way too big.  Please break it up into smaller parts
per patch.

thanks,

greg k-h

  reply	other threads:[~2026-04-27  3:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 10:14 [PATCH 00/11] staging: rtl8723bs: coding style cleanups luka.gejak
2026-04-13 10:14 ` [PATCH 01/11] staging: rtl8723bs: core: fix spacing around operators and casts luka.gejak
2026-04-13 10:14 ` [PATCH 02/11] staging: rtl8723bs: hal: " luka.gejak
2026-04-13 10:14 ` [PATCH 03/11] staging: rtl8723bs: os_dep: fix spacing around operators luka.gejak
2026-04-26 20:04   ` Greg Kroah-Hartman [this message]
2026-04-27  4:46     ` Luka Gejak
2026-04-13 10:14 ` [PATCH 04/11] staging: rtl8723bs: core: align parameters with open parenthesis luka.gejak
2026-04-13 10:14 ` [PATCH 05/11] staging: rtl8723bs: hal: " luka.gejak
2026-04-13 10:14 ` [PATCH 06/11] staging: rtl8723bs: os_dep: " luka.gejak
2026-04-13 10:14 ` [PATCH 07/11] staging: rtl8723bs: core: remove blank lines before closing brace luka.gejak
2026-04-13 10:14 ` [PATCH 08/11] staging: rtl8723bs: hal: " luka.gejak
2026-04-13 10:14 ` [PATCH 09/11] staging: rtl8723bs: os_dep: remove unnecessary braces luka.gejak
2026-04-13 10:14 ` [PATCH 10/11] staging: rtl8723bs: os_dep: remove blank lines before closing braces luka.gejak
2026-04-13 10:14 ` [PATCH 11/11] staging: rtl8723bs: hal: remove unnecessary braces luka.gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026042621-italics-landfall-82b9@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=error27@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=luka.gejak@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox