From: Greg KH <gregkh@linuxfoundation.org>
To: Sachin Kumar <sachinkumar905846@gmail.com>
Cc: andy@kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: fbtft: clarify TODO comment in fbtft-core
Date: Sun, 26 Apr 2026 21:20:08 +0200 [thread overview]
Message-ID: <2026042631-resolved-outline-2946@gregkh> (raw)
In-Reply-To: <20260417093303.33670-1-sachinkumar905846@gmail.com>
On Fri, Apr 17, 2026 at 03:03:03PM +0530, Sachin Kumar wrote:
> Improve wording of a TODO comment to better describe the
> intended optimization. The comment now clearly states that
> only the changed display area should be updated instead of
> refreshing the entire screen.
>
> Signed-off-by: Sachin Kumar <sachinkumar905846@gmail.com>
> ---
> v3:
> - add missing changelog for previous version
> - simplify TODO comment to match kernel style
>
> drivers/staging/fbtft/fbtft-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index f427c0914..cff838955 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -414,7 +414,7 @@ static void fbtft_ops_damage_range(struct fb_info *info, off_t off, size_t len)
> {
> struct fbtft_par *par = info->par;
>
> - /* TODO: only mark changed area update all for now */
> + /* TODO: update only changed area, not entire display */
> par->fbtftops.mkdirty(info, -1, 0);
> }
>
> --
> 2.43.0
>
Does not apply to the tree anymore :(
prev parent reply other threads:[~2026-04-27 3:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 16:46 [PATCH] staging: fbtft: clarify TODO comment in fbtft-core Sachin Kumar
2026-04-16 18:20 ` Andy Shevchenko
2026-04-16 18:48 ` Sachin Kumar
2026-04-16 18:54 ` [PATCH v2] " Sachin Kumar
2026-04-17 6:24 ` Greg KH
2026-04-17 9:33 ` [PATCH v3] " Sachin Kumar
2026-04-26 19:20 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026042631-resolved-outline-2946@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sachinkumar905846@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox