From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andrei Khomenkov <khomenkov@mailbox.org>
Cc: Ethan Tidmore <ethantidmore06@gmail.com>,
Dan Carpenter <error27@gmail.com>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v5 1/3] staging: rtl8723bs: simplify boolean comparisons
Date: Sun, 26 Apr 2026 22:15:12 +0200 [thread overview]
Message-ID: <2026042639-trade-resolute-cac8@gregkh> (raw)
In-Reply-To: <20260421220058.29317-2-khomenkov@mailbox.org>
On Wed, Apr 22, 2026 at 01:00:56AM +0300, Andrei Khomenkov wrote:
> Simplify boolean comparisons to improve readability
> and conform to the Linux kernel coding style.
>
> Signed-off-by: Andrei Khomenkov <khomenkov@mailbox.org>
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
> drivers/staging/rtl8723bs/core/rtw_btcoex.c | 2 +-
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> .../staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
> .../staging/rtl8723bs/core/rtw_ioctl_set.c | 54 +++++++-------
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 ++--
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 16 ++---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 71 +++++++++----------
> drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +-
> .../staging/rtl8723bs/core/rtw_wlan_util.c | 18 ++---
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 34 ++++-----
> drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 +--
> drivers/staging/rtl8723bs/hal/hal_com.c | 4 +-
> .../staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +-
> drivers/staging/rtl8723bs/hal/hal_intf.c | 4 +-
> drivers/staging/rtl8723bs/hal/odm.c | 8 +--
> .../staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +-
> drivers/staging/rtl8723bs/hal/odm_DIG.c | 24 +++----
> drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +-
> drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 12 ++--
> .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 ++--
> .../staging/rtl8723bs/hal/rtl8723bs_recv.c | 2 +-
> .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 8 +--
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +-
> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 52 +++++++-------
> .../staging/rtl8723bs/os_dep/sdio_ops_linux.c | 4 +-
> drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +-
> 27 files changed, 184 insertions(+), 185 deletions(-)
This is big, and conflicts with patches from others sent before you.
Can you break this up into a smaller patch series, maybe one per file,
or sub-dir?
thanks,
greg k-h
next prev parent reply other threads:[~2026-04-27 3:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 22:00 [PATCH v5 0/3] staging: rtl8723bs: simplify booleans and cleanup style Andrei Khomenkov
2026-04-21 22:00 ` [PATCH v5 1/3] staging: rtl8723bs: simplify boolean comparisons Andrei Khomenkov
2026-04-26 20:15 ` Greg Kroah-Hartman [this message]
2026-04-21 22:00 ` [PATCH v5 2/3] staging: rtl8723bs: add spaces around bitwise OR operators Andrei Khomenkov
2026-04-21 22:00 ` [PATCH v5 3/3] staging: rtl8723bs: cleanup if-statements formatting Andrei Khomenkov
2026-04-26 20:16 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026042639-trade-resolute-cac8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=error27@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=khomenkov@mailbox.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox