public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alexandru Hossu <hossu.alexandru@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	error27@gmail.com, linux-tegra@vger.kernel.org, marvin24@gmx.de
Subject: Re: [PATCH v3] staging: nvec: fix unconditional pm_power_off teardown
Date: Sun, 26 Apr 2026 21:04:14 +0200	[thread overview]
Message-ID: <2026042640-cultivate-flagman-0665@gregkh> (raw)
In-Reply-To: <20260413200203.726726-1-hossu.alexandru@gmail.com>

On Mon, Apr 13, 2026 at 10:02:03PM +0200, Alexandru Hossu wrote:
> tegra_nvec_remove() unconditionally sets pm_power_off = NULL, even if
> nvec was not the one that registered it. This breaks any other driver
> that may have set pm_power_off to its own handler.
> 
> Replace the unconditional assignment with a guarded check so that
> pm_power_off is only cleared if nvec was the one that set it.
> 
> Also remove the stale FIXME comment, as the guard addresses exactly
> what it was asking for.
> 
> Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>
> ---
> v3:
>  - Drop incorrect Fixes tag

I'm confused, I see lots of different patches here, with this final
thread looking like this:

 Apr 13 Alexandru Hossu (  51) [PATCH v2 1/2] staging: nvec: fix use-after-free in nvec_rx_completed()
 Apr 13 Alexandru Hossu (  40) └─>[PATCH v2 2/2] staging: nvec: fix unconditional pm_power_off teardown
 Apr 13 Dan Carpenter   (  26)   ├─>
 Apr 13 Alexandru Hossu (  42)   └─>[PATCH v3] staging: nvec: fix unconditional pm_power_off teardown

What is patch v3 of?  What about patch 1/2?

This is really confusing.

When redoing a patch in a series, you need to resend the whole series as
a new version.  Otherwise I have no idea what to do (and our tools get
_VERY_ confused as well.)

So a v4 full series please?

thanks,

greg k-h


      reply	other threads:[~2026-04-27  3:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 15:12 [PATCH v2 1/2] staging: nvec: fix use-after-free in nvec_rx_completed() Alexandru Hossu
2026-04-13 15:12 ` [PATCH v2 2/2] staging: nvec: fix unconditional pm_power_off teardown Alexandru Hossu
2026-04-13 17:51   ` Dan Carpenter
2026-04-13 20:02   ` [PATCH v3] " Alexandru Hossu
2026-04-26 19:04     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026042640-cultivate-flagman-0665@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=error27@gmail.com \
    --cc=hossu.alexandru@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux-tegra@vger.kernel.org \
    --cc=marvin24@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox