public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Lettice up <minecraftwemmne@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c
Date: Sun, 26 Apr 2026 09:03:11 +0200	[thread overview]
Message-ID: <2026042652-starving-dejected-6c89@gregkh> (raw)
In-Reply-To: <CAJYuYVmJ93xKgV2cT8=C5ah2e8Cg47tHEEBr4ka59K9Bogq96Q@mail.gmail.com>

On Sun, Apr 26, 2026 at 02:41:38PM +0800, Lettice up wrote:
> From: Lettice <minecraftwemmne@gmail.com>
> 
> Date: Sun, 26 Apr 2026 00:49:40 -0400
> 
> Subject: [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c
> 
> 
> Fix a checkpatch.pl warning where a line exceeds 100 columns
> 
> by breaking the long memcpy() call into two lines.
> 
> 
> Signed-off-by: Lettice <minecraftwemmne@gmail.com>
> 
> ---
> 
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 ++-
> 
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> 
> index c1185c25ed36..50662d44a4b6 100644
> 
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> 
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> 
> @@ -557,7 +557,8 @@ u8 rtw_sitesurvey_cmd(struct adapter  *padapter,
> struct ndis_802_11_ssid *ssid,
> 
> 
> 
>                 for (i = 0; i < ssid_num && i < RTW_SSID_SCAN_AMOUNT; i++) {
> 
>                         if (ssid[i].ssid_length) {
> 
> -                               memcpy(&psurveyPara->ssid[i],
> &ssid[i], sizeof(struct ndis_802_11_ssid));
> 
> +                               memcpy(&psurveyPara->ssid[i], &ssid[i],
> 
> +                                      sizeof(struct ndis_802_11_ssid));
> 
>                                 psurveyPara->ssid_num++;
> 
>                         }
> 
>                 }
> 
> --
> 
> 2.53.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

  reply	other threads:[~2026-04-26  7:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26  6:41 [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c Lettice up
2026-04-26  7:03 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-26 10:20 Lettice up
2026-04-26 19:40 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026042652-starving-dejected-6c89@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=minecraftwemmne@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox