From: Greg KH <gregkh@linuxfoundation.org>
To: Xiyuan Guo <tommyguo039@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
b9788213@gmail.com
Subject: Re: [PATCH v3] staging: rtl8723bs: remove GEN_CMD_CODE macro and callback array
Date: Sun, 26 Apr 2026 22:18:05 +0200 [thread overview]
Message-ID: <2026042658-lapping-uneaten-d7a4@gregkh> (raw)
In-Reply-To: <20260403005218.300096-1-tommyguo039@gmail.com>
On Thu, Apr 02, 2026 at 08:51:58PM -0400, Xiyuan Guo wrote:
> The GEN_CMD_CODE macro and the rtw_cmd_callback function pointer array
> add unnecessary layers of indirection and make the code difficult to
> follow. Remove the GEN_CMD_CODE macro and replace the function pointer
> array dispatcher in rtw_cmd_thread() with a direct switch statement.
>
> Additionally, rename the associated command enums from CamelCase to
> UPPERCASE_SNAKE_CASE to comply with the standard Linux kernel coding
> style.
>
> Signed-off-by: Xiyuan Guo <tommyguo039@gmail.com>
I like the idea, but this worries me as now you just dropped a bunch of
"unused" entries that kind of documented things. Have you tested this
change on a device this driver controls to verify it still works?
thanks,
greg k-h
prev parent reply other threads:[~2026-04-27 3:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 0:51 [PATCH v3] staging: rtl8723bs: remove GEN_CMD_CODE macro and callback array Xiyuan Guo
2026-04-26 20:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026042658-lapping-uneaten-d7a4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=b9788213@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tommyguo039@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox