From: Debjeet Banerjee <debjeetbanerjee48@gmail.com>
To: gregkh@linuxfoundation.org
Cc: debjeetbanerjee48@gmail.com, dtwlin@gmail.com, elder@kernel.org,
greybus-dev@lists.linaro.org, johan@kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: uart: document c_cflag handling in set_termios
Date: Mon, 27 Apr 2026 09:45:53 +0530 [thread overview]
Message-ID: <20260427041553.6323-1-debjeetbanerjee48@gmail.com> (raw)
In-Reply-To: <2026042618-whole-cassette-b15e@gregkh>
On Sun, 26 Apr 2026 21:16:05 +0200, Greg Kroah-Hartman wrote:
> Ignoring is fine, but shouldn't the bits be cleared to let userspace
> know about this? I think that's why we wrote that FIXME all so long
> ago.
Thanks for the feedback.
That makes sense. I had considered clearing unsupported bits earlier, but held off to
avoid modifying termios and left them ignored instead. Your point about userspace
visibility makes sense.
I'll send a v2 that clears unsupported c_cflag bits accordingly.
Regards,
Debjeet
next prev parent reply other threads:[~2026-04-27 4:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 3:26 [PATCH] staging: greybus: uart: document c_cflag handling in set_termios Debjeet Banerjee
2026-04-26 19:16 ` Greg KH
2026-04-27 4:15 ` Debjeet Banerjee [this message]
2026-04-27 4:54 ` [PATCH v2] staging: greybus: uart: clear unsupported c_cflag bits " Debjeet Banerjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427041553.6323-1-debjeetbanerjee48@gmail.com \
--to=debjeetbanerjee48@gmail.com \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox