Re: [PATCH v5 1/4] staging: octeon: ethernet-mem: replace pr_warn with dev_warn in free functions

Greg KH
2026-05-04T14:56:25Z

On Mon, Apr 27, 2026 at 08:45:52PM +0530, Ayush Mukkanwar wrote:
> Replace pr_warn() calls with dev_warn() in the hardware pool free
> functions (cvm_oct_free_hw_skbuff and cvm_oct_free_hw_memory)
> to include device information in log messages. The struct device
> pointer is passed from cvm_oct_remove() through
> cvm_oct_mem_empty_fpa() to the internal free functions.

Why aren't you passing through the platform device pointer? Why deal
with the "raw" struct device? Always try to keep the "highest level"
pointer to work with where ever possible.

thanks,

greg k-h