From: Salman Alghamdi <me@cipherat.com>
To: gregkh@linuxfoundation.org
Cc: luka.gejak@linux.dev, straube.linux@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v4 5/7] staging: rtl8723bs: rtw_mlme: remove dead commented-out code
Date: Mon, 27 Apr 2026 22:05:33 +0300 [thread overview]
Message-ID: <20260427190548.156499-6-me@cipherat.com> (raw)
In-Reply-To: <20260427190548.156499-1-me@cipherat.com>
Remove commented-out code and its associated orphaned comments.
Signed-off-by: Salman Alghamdi <me@cipherat.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 22 ++--------------------
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 98271cea2bf2..47c0d176dbdc 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -750,9 +750,6 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)
struct wlan_bssid_ex *pdev_network = ®s->dev_network;
u8 *pibss = regs->dev_network.mac_address;
- /* pmlmepriv->fw_state ^= _FW_UNDER_SURVEY;
- * because don't set assoc_timer
- */
_clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY);
memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid,
@@ -1062,7 +1059,7 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter,
preorder_ctrl->enable = false;
preorder_ctrl->indicate_seq = 0xffff;
preorder_ctrl->wend_b = 0xffff;
- preorder_ctrl->wsize_b = 64;/* max_ampdu_sz;ex. 32(kbytes) -> wsize_b =32 */
+ preorder_ctrl->wsize_b = 64;
}
bmc_sta = rtw_get_bcmc_stainfo(padapter);
@@ -1072,7 +1069,6 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter,
preorder_ctrl->enable = false;
preorder_ctrl->indicate_seq = 0xffff;
preorder_ctrl->wend_b = 0xffff;
- /* max_ampdu_sz;ex. 32(kbytes) -> wsize_b =32 */
preorder_ctrl->wsize_b = 64;
}
}
@@ -1712,14 +1708,8 @@ void rtw_dynamic_check_timer_handler(struct adapter *adapter)
linked_status_chk(adapter);
should_enter_ps = traffic_status_watchdog(adapter, true);
- if (should_enter_ps) {
- /* rtw_lps_ctrl_wk_cmd(adapter, LPS_CTRL_ENTER, 1); */
+ if (should_enter_ps)
rtw_hal_dm_watchdog_in_lps(adapter);
- } else {
- /* call rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_LEAVE, 1)
- * in traffic_status_watchdog()
- */
- }
} else {
rtw_dynamic_chk_wk_cmd(adapter);
@@ -2254,19 +2244,11 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter)
/* 1. Supported rates */
/* 2. IE */
- /* rtw_set_supported_rate(pdev_network->supported_rates, pregistrypriv->wireless_mode);
- * will be called in rtw_generate_ie
- */
sz = rtw_generate_ie(pregistrypriv);
pdev_network->ie_length = sz;
pdev_network->length = get_wlan_bssid_ex_sz((struct wlan_bssid_ex *)pdev_network);
-
- /* notes: translate ie_length & length after assign the
- * length to cmdsz in createbss_cmd();
- */
- /* pdev_network->ie_length = cpu_to_le32(sz); */
}
/* the function is at passive_level */
--
2.54.0
next prev parent reply other threads:[~2026-04-27 19:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 19:05 [PATCH v4 0/7] staging: rtl8723bs: rtw_mlme: fix long lines and related issues Salman Alghamdi
2026-04-27 19:05 ` [PATCH v4 1/7] staging: rtl8723bs: fix buffer over-read in rtw_update_protection Salman Alghamdi
2026-04-27 19:05 ` [PATCH v4 2/7] staging: rtl8723bs: rtw_mlme: add bounds checks before ie_length subtraction Salman Alghamdi
2026-04-27 19:05 ` [PATCH v4 3/7] staging: rtl8723bs: rtw_mlme: wrap lines exceeding 100 columns Salman Alghamdi
2026-04-27 19:05 ` [PATCH v4 4/7] staging: rtl8723bs: rtw_mlme: extract local variables for long expressions Salman Alghamdi
2026-04-28 6:07 ` Luka Gejak
2026-04-27 19:05 ` Salman Alghamdi [this message]
2026-04-27 19:05 ` [PATCH v4 6/7] staging: rtl8723bs: rtw_mlme: consolidate capability comparisons lines Salman Alghamdi
2026-04-27 19:05 ` [PATCH v4 7/7] staging: rtl8723bs: rtw_mlme: add blank line for readability Salman Alghamdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427190548.156499-6-me@cipherat.com \
--to=me@cipherat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox