From: Miguel Cyrineu Vale <miguelcvalealt@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
luka.gejak@linux.dev, koike@igalia.com,
~lkcamp/patches@lists.sr.ht, miguelcvalealt@gmail.com
Subject: [PATCH v2] staging: rtl8723bs: replace NULL comparison with NOT operator
Date: Mon, 27 Apr 2026 16:37:59 -0300 [thread overview]
Message-ID: <20260427193759.71642-1-miguelcvalealt@gmail.com> (raw)
In-Reply-To: <20260423184219.827694-1-miguelcvalealt@gmail.com>
Fix checkpatch error "Comparison to NULL could be written "!psta"" in
ioctl_cfg80211.c:2432
Signed-off-by: Miguel Cyrineu Vale <miguelcvalealt@gmail.com>
---
Hey, thanks for the feedback on v1! This is still my first patch, so I'm
learning the ropes with the DCO and formatting.
Changes in v2:
- Use real name in Signed-off-by tag.
- Fix commit message line wrapping and remove unnecessary blank lines.
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index fd3bae31b0ed..8ae3adecafd9 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -2429,7 +2429,7 @@ static int cfg80211_rtw_dump_station(struct wiphy *wiphy,
spin_lock_bh(&pstapriv->asoc_list_lock);
psta = rtw_sta_info_get_by_idx(idx, pstapriv);
spin_unlock_bh(&pstapriv->asoc_list_lock);
- if (psta == NULL) {
+ if (!psta) {
ret = -ENOENT;
goto exit;
}
--
2.53.0
next prev parent reply other threads:[~2026-04-27 19:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 18:42 [PATCH] staging: rtl8723bs: replace NULL comparison with NOT operator mgcvale
2026-04-24 13:39 ` Luka Gejak
2026-04-26 20:11 ` Greg KH
2026-04-27 19:37 ` Miguel Cyrineu Vale [this message]
2026-04-27 19:50 ` [PATCH v2] " Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427193759.71642-1-miguelcvalealt@gmail.com \
--to=miguelcvalealt@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=koike@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox