From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 1/4] staging: rtl8723bs: remove unused SysIntrMask from struct hal_com_data
Date: Mon, 11 May 2026 10:55:28 +0300 [thread overview]
Message-ID: <20260511075651.11637-2-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260511075651.11637-1-nikolayof23@gmail.com>
This field is set to 0 once, and its use becomes optional. Remove it to
clean up dead code.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 4 +---
drivers/staging/rtl8723bs/include/hal_data.h | 1 -
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index 5d74913be573..0c0c243c46eb 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -592,8 +592,6 @@ void InitSysInterrupt8723BSdio(struct adapter *adapter)
struct hal_com_data *haldata;
haldata = GET_HAL_DATA(adapter);
-
- haldata->SysIntrMask = (0);
}
/*
@@ -616,7 +614,7 @@ void rtw_sdio_enable_interrupt(struct adapter *adapter)
/* Update current system IMR settings */
tmp = rtw_read32(adapter, REG_HSIMR);
- rtw_write32(adapter, REG_HSIMR, tmp | haldata->SysIntrMask);
+ rtw_write32(adapter, REG_HSIMR, tmp);
/* */
/* <Roger_Notes> There are some C2H CMDs have been sent before system interrupt is enabled, e.g., C2H, CPWM. */
diff --git a/drivers/staging/rtl8723bs/include/hal_data.h b/drivers/staging/rtl8723bs/include/hal_data.h
index 876b3666aa1c..22c2bac3b80c 100644
--- a/drivers/staging/rtl8723bs/include/hal_data.h
+++ b/drivers/staging/rtl8723bs/include/hal_data.h
@@ -389,7 +389,6 @@ struct hal_com_data {
/* Interrupt related register information. */
u32 SysIntrStatus;
- u32 SysIntrMask;
/* Chip version information */
bool chip_normal; /* true - normal chip, false - test chip */
--
2.54.0
next prev parent reply other threads:[~2026-05-11 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 7:55 [PATCH 0/4] staging: rtl8723bs: remove unused sys interrupt Nikolay Kulikov
2026-05-11 7:55 ` Nikolay Kulikov [this message]
2026-05-11 7:55 ` [PATCH 2/4] staging: rtl8723bs: remove empty InitSysInterrupt8723BSdio() Nikolay Kulikov
2026-05-11 7:55 ` [PATCH 3/4] staging: rtl8723bs: remove overwriting of current IMR settings Nikolay Kulikov
2026-05-11 9:18 ` Dan Carpenter
2026-05-11 13:59 ` Nikolay Kulikov
2026-05-11 7:55 ` [PATCH 4/4] staging: rtl8723bs: remove unused SysIntrStatus from struct hal_com_data Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511075651.11637-2-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox