From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A7E04219E1 for ; Mon, 11 May 2026 16:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778515820; cv=none; b=idG5QEw0QKMK3zvKY6OmnB7J+ZpNoI2F8btOg3MeHRo/j0QHcHmzHXmgs5yXbVTBVxJKs77ia5E1ygNwUyW5jpaOcHk5ttaEl8qQsADEHlESsLfgd4KMmWWsFnFrnDXsFvRJZaLXYkkg6DmpNuOrySx/Wp4giih7C7TRPhW3umo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778515820; c=relaxed/simple; bh=bqiGhSCKd81Tdlu5/C5rJxlJvZzGo177PumJ31CZo5Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=luE06mhoVAGdKsM3sDNQpYDs7QOTPY1dkpzhrxrm8vVInOCzyG3g4OC9M+v61DDI0qh5IKUVtAgeWIpWpDKTK633hH5HHgNuexpwiGxTzbaOdoRQJHMCRG94fvEsPThOFrYkwu9vOaIYKj+pvrnHb/N+eQ3deX0inOkMbKrC/h4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FmTEHRos; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FmTEHRos" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ab077e3f32so21633065ad.3 for ; Mon, 11 May 2026 09:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778515817; x=1779120617; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=plSITfMA010SqNOgu3jqGN/TIycR52TrLYgXH248+w4=; b=FmTEHRosYwM1kNmlxkZAMA1yCKHup+Am8UnQxc8tUfTJp3QZPCts2TH2oWOufnKcwV ckN7VwyPbphXIlaazFnOGW47j0557HGD7xZ7iT6pqpff7UTLuMR6pjRHXCFFgGI0xkr+ OY0ffKReFFmE2qvv5V7AouZSWM5Mq3LbTosTk5KO5gpCLI7NIaROBf1K8KGzmgyWF6AI VgmBCiz0LZxQrLnnFArasroIEP6rQGT3Gcr4KqXp9jG0div5fXC2ejRuL3yURmgV1Dgl RnN/WxfyHpCYu7WXfS24Z0nBnbjw/pgxX/AjC91a3R0MugEH5Ymi7UW9Uzl4yYg/EPEu bcPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778515817; x=1779120617; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=plSITfMA010SqNOgu3jqGN/TIycR52TrLYgXH248+w4=; b=UnQ4XNFmooCVO1jlL5UXUCzRx/DhAwXuJSUkCTAiU4PaNjOr2m9QcODonM2bV9Duhs CfpwArblTxXUiQ7FHoGxcmNQ8lczDcyrV/JrdN7NS4LaGxXa4pcW1fyWNY3OyfJQBBiI qDLLxZiIF+wHUaVj8cHr0ndvElot3Pu2SFa4s+zzxlSDhz3pET02YPTY7dvnqdkUyRN/ rI8dJt+/Ldkx4ePTYhvTlK1v2o48kEd2/6EjO/P+1ho1rk2VdPeGpX9rnkHfB/hpNhFF i7pWlsJ5ueBFfm8jt1SSx0hROppFE8zhNm0DUD0IMPgdKUA4+XmwmAavslSfS6Do14Uo /Ezw== X-Forwarded-Encrypted: i=1; AFNElJ9hkTpswpu18uUV5SIg4s0aitlB14rrdKAcvXEpY1tGK3jeWuM05VUcRAU14IePpQCb4FAafS8UnSdINg+H@lists.linux.dev X-Gm-Message-State: AOJu0Yw9WmwAbjYUAfttG5x+S3KEePlj2u+5wQkrSYdzDRzyX1kebiHX Qk68/qcb4wwlVrx4hvbGoB3ZZWDnQBJecQoYfGzfyNT6EsyMhgU/e+bW X-Gm-Gg: Acq92OEl2t0LyEOWZvMCmjEUZG7ujiU9a9kFg47zDlBF/IPC1avCp3kH5vElXip6JrK GAtKx8i0HYBqxQNdWjKwl10aQvewQHQgJClWMpvIRLp0RF8hPmh5fayEVoAHqpTrDPXDVX0c4VY myTgPRIVIAv4im8V5y4AqcBxUQh8UaF1U+gpBLEJP9Sw+klVgnHHGF2vrNx+hKwKjHph+J+6hrK q+SBCGc2ih42vydggNX/PVYao3Vn7Ur66wGi4YTHOT8gKnu7I7KbJKXEbyzZiGFTTG16k0a7RcU /z1r/salHD/EJIAgcHCLKStGgHXRE43BkxoCVg/d7eEVDOTvJqKfdmuV4p1jPp1ctZHi3H3Y0zh +QVLB6srOkcnUsk08zN3H3/efaPui1iV6XdrEfkDVPFBV7hrhLEYQqa7s5MWjFSdttmyqCncJfO wV85GMfbPYjirWFCa221Da6XasW3thRIfJMrtjzLAwRfqCAUbgJilF2vWc3Rp4NKGekew9nQr0V sjX X-Received: by 2002:a17:903:1a68:b0:2bc:7486:21cf with SMTP id d9443c01a7336-2bc748623e7mr127942635ad.36.1778515816564; Mon, 11 May 2026 09:10:16 -0700 (PDT) Received: from localhost.localdomain ([2404:7c00:52:d485:aae2:91ff:fe57:5e15]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d4057fsm104476225ad.21.2026.05.11.09.10.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 09:10:16 -0700 (PDT) From: Chhabilal Dangal To: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chhabilal Dangal Subject: [PATCH v2] staging: sm750fb: minor coding style cleanup Date: Mon, 11 May 2026 21:54:05 +0545 Message-ID: <20260511160905.29938-1-yogeshdangal66@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Clean up various coding style issues including spacing in struct initializers and indentation of wrapped lines. Signed-off-by: Alone --- drivers/staging/sm750fb/sm750.c | 203 ++++++++++++++++---------------- 1 file changed, 103 insertions(+), 100 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 9f3e3d37e82a..7fca2c9f6966 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -33,7 +33,8 @@ static int g_hwcursor = 1; static int g_noaccel; static int g_nomtrr; -static const char *g_fbmode[] = {NULL, NULL}; +/* intentionally non-const since array is modified at runtime */ +static const char *g_fbmode[] = { NULL, NULL }; static const char *g_def_fbmode = "1024x768-32@60"; static char *g_settings; static int g_dualview; @@ -41,64 +42,62 @@ static char *g_option; static const struct fb_videomode lynx750_ext[] = { /* 1024x600-60 VESA [1.71:1] */ - {NULL, 60, 1024, 600, 20423, 144, 40, 18, 1, 104, 3, - FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 60, 1024, 600, 20423, 144, 40, 18, 1, 104, 3, + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, + FB_VMODE_NONINTERLACED }, /* 1024x600-70 VESA */ - {NULL, 70, 1024, 600, 17211, 152, 48, 21, 1, 104, 3, - FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 70, 1024, 600, 17211, 152, 48, 21, 1, 104, 3, + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, + FB_VMODE_NONINTERLACED }, /* 1024x600-75 VESA */ - {NULL, 75, 1024, 600, 15822, 160, 56, 23, 1, 104, 3, - FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 75, 1024, 600, 15822, 160, 56, 23, 1, 104, 3, + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, + FB_VMODE_NONINTERLACED }, /* 1024x600-85 VESA */ - {NULL, 85, 1024, 600, 13730, 168, 56, 26, 1, 112, 3, - FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 85, 1024, 600, 13730, 168, 56, 26, 1, 112, 3, + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, + FB_VMODE_NONINTERLACED }, /* 720x480 */ - {NULL, 60, 720, 480, 37427, 88, 16, 13, 1, 72, 3, - FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 60, 720, 480, 37427, 88, 16, 13, 1, 72, 3, + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, + FB_VMODE_NONINTERLACED }, /* 1280x720 [1.78:1] */ - {NULL, 60, 1280, 720, 13426, 162, 86, 22, 1, 136, 3, - FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 60, 1280, 720, 13426, 162, 86, 22, 1, 136, 3, + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, + FB_VMODE_NONINTERLACED }, /* 1280x768@60 */ - {NULL, 60, 1280, 768, 12579, 192, 64, 20, 3, 128, 7, - FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 60, 1280, 768, 12579, 192, 64, 20, 3, 128, 7, + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, + FB_VMODE_NONINTERLACED }, /* 1360 x 768 [1.77083:1] */ - {NULL, 60, 1360, 768, 11804, 208, 64, 23, 1, 144, 3, - FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 60, 1360, 768, 11804, 208, 64, 23, 1, 144, 3, + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, + FB_VMODE_NONINTERLACED }, /* 1368 x 768 [1.78:1] */ - {NULL, 60, 1368, 768, 11647, 216, 72, 23, 1, 144, 3, - FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 60, 1368, 768, 11647, 216, 72, 23, 1, 144, 3, + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, + FB_VMODE_NONINTERLACED }, /* 1440 x 900 [16:10] */ - {NULL, 60, 1440, 900, 9392, 232, 80, 28, 1, 152, 3, - FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 60, 1440, 900, 9392, 232, 80, 28, 1, 152, 3, + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED }, /* 1440x960 [15:10] */ - {NULL, 60, 1440, 960, 8733, 240, 88, 30, 1, 152, 3, - FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 60, 1440, 960, 8733, 240, 88, 30, 1, 152, 3, + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, + FB_VMODE_NONINTERLACED }, /* 1920x1080 [16:9] */ - {NULL, 60, 1920, 1080, 6734, 148, 88, 41, 1, 44, 3, - FB_SYNC_VERT_HIGH_ACT, - FB_VMODE_NONINTERLACED}, + { NULL, 60, 1920, 1080, 6734, 148, 88, 41, 1, 44, 3, + FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED }, }; /* no hardware cursor supported under version 2.6.10, kernel bug */ @@ -120,8 +119,7 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) sm750_hw_cursor_disable(cursor); if (fbcursor->set & FB_CUR_SETSIZE) - sm750_hw_cursor_set_size(cursor, - fbcursor->image.width, + sm750_hw_cursor_set_size(cursor, fbcursor->image.width, fbcursor->image.height); if (fbcursor->set & FB_CUR_SETPOS) @@ -134,19 +132,23 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) u16 fg, bg; fg = ((info->cmap.red[fbcursor->image.fg_color] & 0xf800)) | - ((info->cmap.green[fbcursor->image.fg_color] & 0xfc00) >> 5) | - ((info->cmap.blue[fbcursor->image.fg_color] & 0xf800) >> 11); + ((info->cmap.green[fbcursor->image.fg_color] & 0xfc00) >> + 5) | + ((info->cmap.blue[fbcursor->image.fg_color] & 0xf800) >> + 11); bg = ((info->cmap.red[fbcursor->image.bg_color] & 0xf800)) | - ((info->cmap.green[fbcursor->image.bg_color] & 0xfc00) >> 5) | - ((info->cmap.blue[fbcursor->image.bg_color] & 0xf800) >> 11); + ((info->cmap.green[fbcursor->image.bg_color] & 0xfc00) >> + 5) | + ((info->cmap.blue[fbcursor->image.bg_color] & 0xf800) >> + 11); sm750_hw_cursor_set_color(cursor, fg, bg); } if (fbcursor->set & (FB_CUR_SETSHAPE | FB_CUR_SETIMAGE)) { - sm750_hw_cursor_set_data(cursor, fbcursor->rop, fbcursor->image.data, - fbcursor->mask); + sm750_hw_cursor_set_data(cursor, fbcursor->rop, + fbcursor->image.data, fbcursor->mask); } if (fbcursor->enable) @@ -178,7 +180,7 @@ static void lynxfb_ops_fillrect(struct fb_info *info, bpp = info->var.bits_per_pixel >> 3; color = (bpp == 1) ? region->color : - ((u32 *)info->pseudo_palette)[region->color]; + ((u32 *)info->pseudo_palette)[region->color]; rop = (region->rop != ROP_COPY) ? HW_ROP2_XOR : HW_ROP2_COPY; /* @@ -189,11 +191,9 @@ static void lynxfb_ops_fillrect(struct fb_info *info, */ spin_lock(&sm750_dev->slock); - sm750_dev->accel.de_fillrect(&sm750_dev->accel, - base, pitch, bpp, - region->dx, region->dy, - region->width, region->height, - color, rop); + sm750_dev->accel.de_fillrect(&sm750_dev->accel, base, pitch, bpp, + region->dx, region->dy, region->width, + region->height, color, rop); spin_unlock(&sm750_dev->slock); } @@ -223,10 +223,9 @@ static void lynxfb_ops_copyarea(struct fb_info *info, */ spin_lock(&sm750_dev->slock); - sm750_dev->accel.de_copyarea(&sm750_dev->accel, - base, pitch, region->sx, region->sy, - base, pitch, bpp, region->dx, region->dy, - region->width, region->height, + sm750_dev->accel.de_copyarea(&sm750_dev->accel, base, pitch, region->sx, + region->sy, base, pitch, bpp, region->dx, + region->dy, region->width, region->height, HW_ROP2_COPY); spin_unlock(&sm750_dev->slock); } @@ -272,12 +271,11 @@ static void lynxfb_ops_imageblit(struct fb_info *info, */ spin_lock(&sm750_dev->slock); - sm750_dev->accel.de_imageblit(&sm750_dev->accel, - image->data, image->width >> 3, 0, - base, pitch, bpp, - image->dx, image->dy, - image->width, image->height, - fgcol, bgcol, HW_ROP2_COPY); + sm750_dev->accel.de_imageblit(&sm750_dev->accel, image->data, + image->width >> 3, 0, base, pitch, bpp, + image->dx, image->dy, image->width, + image->height, fgcol, bgcol, + HW_ROP2_COPY); spin_unlock(&sm750_dev->slock); } @@ -385,7 +383,7 @@ static int lynxfb_ops_set_par(struct fb_info *info) var->height = -1; var->width = -1; - var->accel_flags = 0;/*FB_ACCELF_TEXT;*/ + var->accel_flags = 0; /*FB_ACCELF_TEXT;*/ if (ret) { dev_err(info->device, "bpp %d not supported\n", @@ -498,7 +496,7 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var, var->height = -1; var->width = -1; - var->accel_flags = 0;/* FB_ACCELF_TEXT; */ + var->accel_flags = 0; /* FB_ACCELF_TEXT; */ /* check if current fb's video memory big enough to hold the onscreen*/ request = var->xres_virtual * (var->bits_per_pixel >> 3); @@ -514,12 +512,9 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var, return hw_sm750_crtc_check_mode(crtc, var); } -static int lynxfb_ops_setcolreg(unsigned int regno, - unsigned int red, - unsigned int green, - unsigned int blue, - unsigned int transp, - struct fb_info *info) +static int lynxfb_ops_setcolreg(unsigned int regno, unsigned int red, + unsigned int green, unsigned int blue, + unsigned int transp, struct fb_info *info) { struct lynxfb_par *par; struct lynxfb_crtc *crtc; @@ -556,8 +551,7 @@ static int lynxfb_ops_setcolreg(unsigned int regno, if (info->fix.visual == FB_VISUAL_TRUECOLOR && regno < 256) { u32 val; - if (var->bits_per_pixel == 16 || - var->bits_per_pixel == 32 || + if (var->bits_per_pixel == 16 || var->bits_per_pixel == 32 || var->bits_per_pixel == 24) { val = chan_to_field(red, &var->red); val |= chan_to_field(green, &var->green); @@ -616,7 +610,8 @@ static int sm750fb_set_drv(struct lynxfb_par *par) /* chip specific phase */ sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ? - hw_sm750le_de_wait : hw_sm750_de_wait; + hw_sm750le_de_wait : + hw_sm750_de_wait; switch (sm750_dev->dataflow) { case sm750_simul_pri: output->paths = sm750_pnc; @@ -670,7 +665,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par) static const struct fb_ops lynxfb_ops = { .owner = THIS_MODULE, FB_DEFAULT_IOMEM_OPS, - .fb_check_var = lynxfb_ops_check_var, + .fb_check_var = lynxfb_ops_check_var, .fb_set_par = lynxfb_ops_set_par, .fb_setcolreg = lynxfb_ops_setcolreg, .fb_blank = lynxfb_ops_blank, @@ -680,7 +675,7 @@ static const struct fb_ops lynxfb_ops = { static const struct fb_ops lynxfb_ops_with_cursor = { .owner = THIS_MODULE, FB_DEFAULT_IOMEM_OPS, - .fb_check_var = lynxfb_ops_check_var, + .fb_check_var = lynxfb_ops_check_var, .fb_set_par = lynxfb_ops_set_par, .fb_setcolreg = lynxfb_ops_setcolreg, .fb_blank = lynxfb_ops_blank, @@ -691,7 +686,7 @@ static const struct fb_ops lynxfb_ops_with_cursor = { static const struct fb_ops lynxfb_ops_accel = { .owner = THIS_MODULE, __FB_DEFAULT_IOMEM_OPS_RDWR, - .fb_check_var = lynxfb_ops_check_var, + .fb_check_var = lynxfb_ops_check_var, .fb_set_par = lynxfb_ops_set_par, .fb_setcolreg = lynxfb_ops_setcolreg, .fb_blank = lynxfb_ops_blank, @@ -705,7 +700,7 @@ static const struct fb_ops lynxfb_ops_accel = { static const struct fb_ops lynxfb_ops_accel_with_cursor = { .owner = THIS_MODULE, __FB_DEFAULT_IOMEM_OPS_RDWR, - .fb_check_var = lynxfb_ops_check_var, + .fb_check_var = lynxfb_ops_check_var, .fb_set_par = lynxfb_ops_set_par, .fb_setcolreg = lynxfb_ops_setcolreg, .fb_blank = lynxfb_ops_blank, @@ -728,11 +723,14 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) struct fb_fix_screeninfo *fix; const struct fb_videomode *pdb[] = { - lynx750_ext, NULL, vesa_modes, + lynx750_ext, + NULL, + vesa_modes, }; - int cdb[] = {ARRAY_SIZE(lynx750_ext), 0, VESA_MODEDB_SIZE}; + int cdb[] = { ARRAY_SIZE(lynx750_ext), 0, VESA_MODEDB_SIZE }; static const char *fix_id[2] = { - "sm750_fb1", "sm750_fb2", + "sm750_fb1", + "sm750_fb2", }; int ret, line_length; @@ -755,8 +753,8 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) * must be set after crtc member initialized */ crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024; - crtc->cursor.mmio = sm750_dev->pvReg + - 0x800f0 + (int)crtc->channel * 0x140; + crtc->cursor.mmio = + sm750_dev->pvReg + 0x800f0 + (int)crtc->channel * 0x140; crtc->cursor.max_h = 64; crtc->cursor.max_w = 64; @@ -788,8 +786,8 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) } for (i = 0; i < 3; i++) { - ret = fb_find_mode(var, info, g_fbmode[index], - pdb[i], cdb[i], NULL, 8); + ret = fb_find_mode(var, info, g_fbmode[index], pdb[i], cdb[i], + NULL, 8); if (ret == 1 || ret == 2) break; @@ -901,7 +899,8 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) dev_info(&sm750_dev->pdev->dev, "find fbmode1 : %s\n", g_fbmode[1]); } else { - dev_warn(&sm750_dev->pdev->dev, "How many view you wann set?\n"); + dev_warn(&sm750_dev->pdev->dev, + "How many view you wann set?\n"); } } } @@ -1112,8 +1111,12 @@ static int __init lynxfb_setup(char *options) } static const struct pci_device_id smi_pci_table[] = { - { PCI_DEVICE(0x126f, 0x0750), }, - {0,} + { + PCI_DEVICE(0x126f, 0x0750), + }, + { + 0, + } }; MODULE_DEVICE_TABLE(pci, smi_pci_table); @@ -1121,11 +1124,11 @@ MODULE_DEVICE_TABLE(pci, smi_pci_table); static SIMPLE_DEV_PM_OPS(lynxfb_pm_ops, lynxfb_suspend, lynxfb_resume); static struct pci_driver lynxfb_driver = { - .name = "sm750fb", - .id_table = smi_pci_table, - .probe = lynxfb_pci_probe, - .remove = lynxfb_pci_remove, - .driver.pm = &lynxfb_pm_ops, + .name = "sm750fb", + .id_table = smi_pci_table, + .probe = lynxfb_pci_probe, + .remove = lynxfb_pci_remove, + .driver.pm = &lynxfb_pm_ops, }; static int __init lynxfb_init(void) @@ -1155,15 +1158,15 @@ module_exit(lynxfb_exit); module_param(g_option, charp, 0444); -MODULE_PARM_DESC(g_option, - "\n\t\tCommon options:\n" - "\t\tnoaccel:disable 2d capabilities\n" - "\t\tnomtrr:disable MTRR attribute for video memory\n" - "\t\tdualview:dual frame buffer feature enabled\n" - "\t\tnohwc:disable hardware cursor\n" - "\t\tUsual example:\n" - "\t\tinsmod ./sm750fb.ko g_option=\"noaccel,nohwc,1280x1024-8@60\"\n" - ); +MODULE_PARM_DESC( + g_option, + "\n\t\tCommon options:\n" + "\t\tnoaccel:disable 2d capabilities\n" + "\t\tnomtrr:disable MTRR attribute for video memory\n" + "\t\tdualview:dual frame buffer feature enabled\n" + "\t\tnohwc:disable hardware cursor\n" + "\t\tUsual example:\n" + "\t\tinsmod ./sm750fb.ko g_option=\"noaccel,nohwc,1280x1024-8@60\"\n"); MODULE_AUTHOR("monk liu "); MODULE_AUTHOR("Sudip Mukherjee "); -- 2.54.0