From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2641D395AD7; Tue, 12 May 2026 10:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778581050; cv=none; b=aj9JycjCs0RbTqd96k8luu3z8qCF5JEIchdmkLkI/VGxQoi+NiuM/5/sr8ptrEFJ2sPqVLCzx6PnINNzdH7o63/Euha6d6//NT3Bt6c7iVwkKgM+q8yJAlyXowWB5bps+kUhWDCzuqRTVP9tIQEuUOxsCZf4tlntgNKVE9Wit7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778581050; c=relaxed/simple; bh=Xf/dZSb4r/xorL3Z004zEE2WN5eXTDvsTSt9dICU6jU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iyOKJ8ESrTrkzSjjt/PfiHZtiHRibiAF8HJJI4f6749HrzU6VyaOMqqXgU06TJYD2FVDMV7tBMF9iqVPvEc+Pms6vVUq1WI4/c8hmUIqLeRpBBy3m1e0FKTb9sAjpgOwrL4ZkGDy5NdhE1TIy2UuBckQViRg5R4oLfMOemXPvE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WzkoRyrK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WzkoRyrK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32A7CC2BCB0; Tue, 12 May 2026 10:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778581049; bh=Xf/dZSb4r/xorL3Z004zEE2WN5eXTDvsTSt9dICU6jU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WzkoRyrKcGg/bp+KVynim/KWvs4CKaRmE/hZdfUYUA+72r/dAd7eLumhr0JGAv+Qe EoXYHrCTZw+UhQaFx4GtS873mGzEPlFbBsUufDZXNuPBEv6VXh9MNFkknk1eMq4Kqd f7N+S9WMXtfYCug6tePMzg6ZNp3gtMBy03VDcZ2H2sfaHFhY2/kGEhbBL4sNQSnKGu o2yTwb8+WxXNb3TROm0nyLJSBv6LzQUC2TAJDJltWXMbcxj/srRYIUaJZUogbogTsx ylj2LdaOyRwTTPRM1Wg5qxEy9SzwDVECR08yV2nxnKZGrCH+Mpg6UGZhkj2KNEcahZ WlV8SM5if0o/Q== Date: Tue, 12 May 2026 11:17:23 +0100 From: Lee Jones To: Benjamin Tissoires Cc: Jiri Kosina , Filipe =?iso-8859-1?Q?La=EDns?= , Bastien Nocera , Ping Cheng , Jason Gerecke , Viresh Kumar , Johan Hovold , Alex Elder , Greg Kroah-Hartman , Icenowy Zheng , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 0/4] HID: Proper fix for OOM in hid-core Message-ID: <20260512101723.GU305027@google.com> References: <20260504-wip-fix-core-v3-0-ce1f11f4968f@kernel.org> <20260506091606.GB305027@google.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260506091606.GB305027@google.com> On Wed, 06 May 2026, Lee Jones wrote: > On Mon, 04 May 2026, Benjamin Tissoires wrote: > > > Commit 0a3fe972a7cb ("HID: core: Mitigate potential OOB by removing > > bogus memset()") enforced the provided data to be at least the size of > > the declared buffer in the report descriptor to prevent a buffer > > overflow. > > > > We only had corner cases of malicious devices exposing the OOM because > > in most cases, the buffer provided by the transport layer needs to be > > allocated at probe time and is large enough to handle all the possible > > reports. > > > > However, the patch from above, which enforces the spec a little bit more > > introduced both regressions for devices not following the spec (not > > necesserally malicious), but also a stream of errors for those devices. > > > > Let's revert to the old behavior by giving more information to HID core > > to be able to decide whether it can or not memset the rest of the buffer > > to 0 and continue the processing. > > > > Note that the first commit makes an API change, but the callers are > > relatively limited, so it should be fine on its own. The second patch > > can't really make the same kind of API change because we have too many > > callers in various subsystems. We can switch them one by one to the safe > > approach when needed. > > > > The last 2 patches are small cleanups I initially put together with the > > 2 first patches, but they can be applied on their own and don't need to > > be pulled in stable like the first 2. > > > > Cheers, > > Benjamin > > > > Signed-off-by: Benjamin Tissoires > > --- > > Changes in v3: > > - fixed ghib -> ghid in greybus > > - fixed i386 size_t debug size reported by kernel-bot > > - Link to v2: https://lore.kernel.org/r/20260416-wip-fix-core-v2-0-be92570e5627@kernel.org > > > > Changes in v2: > > - added a small blurb explaining the difference between the safe and the > > non safe version of hid_safe_input_report > > - Link to v1: https://lore.kernel.org/r/20260415-wip-fix-core-v1-0-ed3c4c823175@kernel.org > > > > --- > > Benjamin Tissoires (4): > > HID: pass the buffer size to hid_report_raw_event > > HID: core: introduce hid_safe_input_report() > > HID: multitouch: use __free(kfree) to clean up temporary buffers > > HID: wacom: use __free(kfree) to clean up temporary buffers > > > > drivers/hid/bpf/hid_bpf_dispatch.c | 6 ++-- > > drivers/hid/hid-core.c | 67 ++++++++++++++++++++++++++++++-------- > > drivers/hid/hid-gfrm.c | 4 +-- > > drivers/hid/hid-logitech-hidpp.c | 2 +- > > drivers/hid/hid-multitouch.c | 18 ++++------ > > drivers/hid/hid-primax.c | 2 +- > > drivers/hid/hid-vivaldi-common.c | 2 +- > > drivers/hid/i2c-hid/i2c-hid-core.c | 7 ++-- > > drivers/hid/usbhid/hid-core.c | 11 ++++--- > > drivers/hid/wacom_sys.c | 46 +++++++++----------------- > > drivers/staging/greybus/hid.c | 2 +- > > include/linux/hid.h | 6 ++-- > > include/linux/hid_bpf.h | 14 +++++--- > > 13 files changed, 109 insertions(+), 78 deletions(-) > > What's the plan for this set Benjamin? -rcs or -next? Are there any updates on this set please? FYI, this set is still important to us. Ideally, if all is well, it would go into the -rcs for v7.1. -- Lee Jones