Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Cong Nguyen <congnt264@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: rename ndis_802_11_network_infrastructure enum values to uppercase
Date: Thu, 21 May 2026 11:10:49 +0200	[thread overview]
Message-ID: <2026052117-snore-bladder-110d@gregkh> (raw)
In-Reply-To: <20260511134930.4086521-1-congnt264@gmail.com>

On Mon, May 11, 2026 at 08:49:30PM +0700, Cong Nguyen wrote:
> --- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> +++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> @@ -43,11 +43,11 @@ struct ndis_802_11_conf {
>  };
>  
>  enum ndis_802_11_network_infrastructure {
> -	Ndis802_11IBSS,
> -	Ndis802_11Infrastructure,
> -	Ndis802_11AutoUnknown,
> -	Ndis802_11InfrastructureMax,     /*  Not a real value, defined as upper bound */
> -	Ndis802_11APMode,
> +	NDIS_802_11_IBSS,
> +	NDIS_802_11_INFRASTRUCTURE,
> +	NDIS_802_11_AUTO_UNKNOWN,
> +	NDIS_802_11_INFRASTRUCTURE_MAX,     /*  Not a real value, defined as upper bound */
> +	NDIS_802_11_AP_MODE,
>  };

Why aren't you just using the NDIS values that the kernel already
provides for these?  Don't re-invent the wheel.

thanks,

greg k-h

      reply	other threads:[~2026-05-21  9:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 13:49 [PATCH] staging: rtl8723bs: rename ndis_802_11_network_infrastructure enum values to uppercase Cong Nguyen
2026-05-21  9:10 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026052117-snore-bladder-110d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=congnt264@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox