From: Greg KH <gregkh@linuxfoundation.org>
To: Praveen Jayaprakash Pattar <praveen.pattar2022@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: hal: Remove unnecessary blank lines in hal_com.c
Date: Thu, 21 May 2026 12:42:08 +0200 [thread overview]
Message-ID: <2026052155-bottom-synergy-e6fc@gregkh> (raw)
In-Reply-To: <20260517171537.17787-1-praveen.pattar2022@gmail.com>
On Sun, May 17, 2026 at 10:45:37PM +0530, Praveen Jayaprakash Pattar wrote:
> Remove multiple consecutive blank lines that violate kernel coding style.
> Detected by checkpatch.pl with --strict flag.
>
> Signed-off-by: Praveen Jayaprakash Pattar <praveen.pattar2022@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/hal_com.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
> index 728a2171f..de1fe8a98 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com.c
> @@ -30,7 +30,6 @@ void rtw_hal_data_deinit(struct adapter *padapter)
> }
> }
>
> -
> void dump_chip_info(struct hal_version chip_version)
> {
> char buf[128];
> @@ -71,7 +70,6 @@ void dump_chip_info(struct hal_version chip_version)
> cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", chip_version.ROMVer);
> }
>
> -
> #define EEPROM_CHANNEL_PLAN_BY_HW_MASK 0x80
>
> /*
> @@ -378,7 +376,6 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
>
> } else { /* typical setting */
>
> -
> /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> /* 1, 1, 0, 0, 0, 0, 0, 0, 0 }; */
> /* 0:ep_0 num, 1:ep_1 num */
> @@ -419,7 +416,6 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
>
> } else { /* typical setting */
>
> -
> /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> /* 2, 2, 1, 0, 0, 0, 0, 0, 0 }; */
> /* 0:H, 1:N, 2:L */
> @@ -751,7 +747,6 @@ void SetHalODMVar(
> }
> }
>
> -
> bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 *pInt)
> {
> u16 i = 0;
> --
> 2.54.0
>
>
Someone else sent this same change right before you did, sorry.
prev parent reply other threads:[~2026-05-21 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 17:15 [PATCH] staging: rtl8723bs: hal: Remove unnecessary blank lines in hal_com.c Praveen Jayaprakash Pattar
2026-05-21 10:42 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026052155-bottom-synergy-e6fc@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=praveen.pattar2022@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox