From: Greg KH <gregkh@linuxfoundation.org>
To: Jinyuan Guo <guojy.bj@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/2] staging: sm750fb: rename CamelCase variable pvReg and drop prefix
Date: Fri, 22 May 2026 08:22:34 +0200 [thread overview]
Message-ID: <2026052214-handlebar-exploring-33f7@gregkh> (raw)
In-Reply-To: <CAGRbmwj0=ybZSyV+xPzHo3T=5b+cpCvyt0du=4dhw_Tuv_6n0g@mail.gmail.com>
On Thu, May 21, 2026 at 11:14:45PM -0700, Jinyuan Guo wrote:
> On Thu, May 21, 2026 at 2:11 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, May 11, 2026 at 10:41:23AM -0700, Jennifer Guo wrote:
> > > Renames the CamelCase variable 'pvReg' in struct sm750_dev to 'vreg'.
> > > Dropping the pointer prefix 'p'.
> >
> > Why are you keeping the prefix "v"?
> >
> > Please don't keep the "hungarian" notation at all.
>
> Thanks for the feedback!
>
> Based on reading the surrounding code in the header - specifically
> vidmem_size and vidreg_size - I assumed the 'v' stood for video
> (and not void) and should thus be kept.
>
> One related note, I have another committed patch: f50b4602fea6
> (staging: sm750fb: rename CamelCase variable and drop prefix)
> where I renamed 'pvMem' to 'vmem', so depending on what the conclusion
> here is, should I then also update 'vmem' ?
You probably should fix that up too, sorry for missing that.
thanks,
greg k-h
next prev parent reply other threads:[~2026-05-22 6:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 17:41 [PATCH 0/2] staging: sm750fb: fix 2 CamelCase variables Jennifer Guo
2026-05-11 17:41 ` [PATCH 1/2] staging: sm750fb: rename CamelCase variable pvReg and drop prefix Jennifer Guo
2026-05-21 9:11 ` Greg KH
2026-05-22 6:14 ` Jinyuan Guo
2026-05-22 6:22 ` Greg KH [this message]
2026-05-11 17:41 ` [PATCH 2/2] staging: sm750fb: rename CamelCase variable setAllEngOff Jennifer Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026052214-handlebar-exploring-33f7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=guojy.bj@gmail.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox