Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeongin Yeo <jeongin.yeo@luaberry.com>
Cc: hansg@kernel.org, mchehab@kernel.org,
	sakari.ailus@linux.intel.com, andy@kernel.org,
	matt@mattwardle.net, linux-media@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: atomisp: use __func__ in debug messages in binary.c
Date: Tue, 26 May 2026 18:21:29 +0200	[thread overview]
Message-ID: <2026052613-glamour-caress-1b8a@gregkh> (raw)
In-Reply-To: <20260526104750.1284935-1-jeongin.yeo@luaberry.com>

On Tue, May 26, 2026 at 10:47:50AM +0000, Jeongin Yeo wrote:
> Replace hardcoded function name strings with __func__ macro in
> dev_dbg() calls within ia_css_binary_find() as recommended by
> kernel coding style.
> 
> No functional changes.
> 
> Signed-off-by: Jeongin Yeo <jeongin.yeo@luaberry.com>
> ---
>  .../atomisp/pci/runtime/binary/src/binary.c   | 127 ++++++++++--------
>  1 file changed, 68 insertions(+), 59 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> index e9016d7775dc3..2355fdf357fcd 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> @@ -925,8 +925,8 @@ int ia_css_binary_find(struct ia_css_binary_descr *descr, struct ia_css_binary *
>  	/* MW: used after an error check, may accept NULL, but doubtful */
>  	assert(binary);
>  
> -	dev_dbg(atomisp_dev, "ia_css_binary_find() enter: descr=%p, (mode=%d), binary=%p\n",
> -		descr, descr->mode, binary);
> +	dev_dbg(atomisp_dev, "%s() enter: descr=%p, (mode=%d), binary=%p\n",
> +		__func__, descr, descr->mode, binary);

dev_dbg() already has __func__ in the output, why is it needed again?

thanks,

greg k-h

  reply	other threads:[~2026-05-26 16:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 10:47 [PATCH] media: atomisp: use __func__ in debug messages in binary.c Jeongin Yeo
2026-05-26 16:21 ` Greg KH [this message]
2026-05-26 19:25   ` Jeongin Yeo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026052613-glamour-caress-1b8a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andy@kernel.org \
    --cc=hansg@kernel.org \
    --cc=jeongin.yeo@luaberry.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=matt@mattwardle.net \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox