From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40DE236B054 for ; Wed, 24 Jun 2026 04:44:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782276263; cv=none; b=DJJvPMThIk2K3zwKTAQPPafTM+zbFpmiemR/oxDKIICHqYF9QEBd4KtWRfPvkOqsvCXGquSlh2yJE+zhiiqdxyDHd71auZtMnON1RIf1MVt0UiCkwc06JPkKc0oiquGIb9Exc2kCxjKmfADtVVjICCVAWB7UIIYhPRCBUXLSJnc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782276263; c=relaxed/simple; bh=Ip1s9CHl8ZzsdAveDPfvFvSCDHHCgPFS/WQP8N+uSTw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vB7EV82WwRA8xLio8hH7r1W83lGXL+D9DklK0vhuZCQ2M7VmjFqy2M6UtLGXmeUxR9aw+Rf3kSUzkv3u36WnbL2lBGBfbCKmZ0IIsFiuXyZbvVNAkQF2MnoW5Z39WkaR+V/HD9hTNd0cCh4OzGDa8UAUluR2dnuPYO8BCh0frz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LBWOUpj7; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LBWOUpj7" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-37c8e7c8185so363107a91.3 for ; Tue, 23 Jun 2026 21:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782276261; x=1782881061; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vHCLB8AQgq5vY37BJcIWdXKDYn7/wlkr75J7OWaF0kQ=; b=LBWOUpj7q7cw7wlgtH/jmVdO7V1r0/RFbtsiedlzbLPhUHhQxoxM0pr9GYmOfKS/ZC xwfWHUhjXFPPq3RtKcy0JP0jUl+Poexi+e7WvCPO6yB0At5j0EnO6yq2G6gNuh0rvjPR 4hnghMZVCY2dXEETejGHtgzGRNUiuIwTKYpSDLlswvYPgyBztTBTJoUhYZPPZ3iXHUCC gbWMHzzhjI6hSfNyZaVTi1rF9byf4Ze0Hz/aYgWr91ruFjJye1dVJp+blDOyA1qt4U/q vU0K4M1o/lhANdeilj6giZrtYfXxKgbS/qkJI0kOpKEePlxUVQB/1/1MFKOwWOF18M6B Um/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782276261; x=1782881061; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vHCLB8AQgq5vY37BJcIWdXKDYn7/wlkr75J7OWaF0kQ=; b=O/Dnde1OiuuZNzrXH9uqf4K79XEAQZgN1sSBFZ/Xawy2068c9Z1Giu42zi0piSZCT+ S5ehl3OQDQJ1ZRsDPF8KY9HE8u/8IH47WP1SxwBB7MwuHnmqxloH4KHrKMYcvohv4OkU W5Pt/mpQykRsTab1hjuxdFJWR5mPIuDPrxoHcOPft9qIj6MBnLM+zQFR9Fmo2PO/oHqo l3rLU+qZbIJXDqTIzx7IpfeZ9sZ0C1nqjUdiH8ZW0KDRbO9siP2f8O8gguSJEA2T0bsJ zxNflKMq3kdg+ZqFCkBWuuSulb+6PG/xIpbh3vP9is0inKnZA/05M4k5Q4Re7MH/y+bZ CIcw== X-Forwarded-Encrypted: i=1; AHgh+RpGkCmWCRcicNoz64EWXzxga3zk8pxGijMcUuA8qKxD3Jwj+CHemiVz2Kz0KHcPshTrwRYxHzY4bVMlP58p@lists.linux.dev X-Gm-Message-State: AOJu0Yw8djgj9gqu4foxoVsFI7kIB8CdTxuWV//mI6okMULlyLHBHhPh nMy3r1fg2bAxj3ku4MKLxPe1GiGqGUda1olyuGSqgUMSH7J/4i3Lrhzd X-Gm-Gg: AfdE7ckvYGP5x6R31kAo5yqU50g8P7GTMM5EZRQFDNgf5EVPwmztvyEF6P0ZjZ1k6ms rdbe1UT6iwK9mc4WzKZ5QROiSfMfKVclc5XRuizq1+1mTL23TYY4RNlzx72gLzYYweSuxS+EkMK pOWOAmEKw3mV3k+UUm5DSfC97eAcEWTzJjW7+4EtHDfB3rk95cTbslc2+WP/RMpR+8ZaZgMyG2R yqY5216f0Eo1TfTIkVDu8X+GorqzZ2X3KR/EGvHydpwMEpI2ps4Ap8Hu4TFIN4OPT0Dm8gE8+n7 hjsycJCtSpZltoEgbBOmc3zCIq6SQABaQ8OlpLM4KL7ckJskukO2pP5+VJXiWO/VuwqVjy4Ts/Q p42n10x7K1rbddyTwuVvRO/YbvBISf4yvfAkTeUQ3geOvvJO9WUOFL5X0J0hKbOChMK4R4pZS1m ILMANyhNiKRxxQRMTqHzVyb1jWBc6x/pgVrdPfYP3qb8kdHXoewSdZsipNuXg/V2piGURJzuY5r RGuskycgj/8b80Rfu5SWxImJrzH0xQ4nnko1QzVtBCFYKFgnOpJ0+G3Kd68u0gdZshM X-Received: by 2002:a17:90b:2fc4:b0:37d:c9b6:437d with SMTP id 98e67ed59e1d1-37de43b3febmr1911850a91.21.1782276259330; Tue, 23 Jun 2026 21:44:19 -0700 (PDT) Received: from kapoor.mahindrauniversity.edu.in ([122.184.65.229]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37de3aa1b1csm1062671a91.5.2026.06.23.21.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 21:44:18 -0700 (PDT) From: Arnav Kapoor To: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Arnav Kapoor , kernel test robot Subject: [PATCH v2] staging: sm750fb: rename CamelCase pvMem and pvReg Date: Wed, 24 Jun 2026 10:14:11 +0530 Message-ID: <20260624044412.67464-1-kapoorarnav43@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename the remaining CamelCase structure members to follow kernel coding style. Rename: * pvMem -> vram * pvReg -> reg Fix build errors by renaming the corresponding structure members in sm750.h as well. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202606240823.hWXfYyPf-lkp@intel.com/ Signed-off-by: Arnav Kapoor --- drivers/staging/sm750fb/sm750.c | 22 +++++++++++----------- drivers/staging/sm750fb/sm750.h | 4 ++-- drivers/staging/sm750fb/sm750_hw.c | 16 ++++++++-------- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 858eda551..efadb9c73 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -622,26 +622,26 @@ static int sm750fb_set_drv(struct lynxfb_par *par) output->paths = sm750_pnc; crtc->channel = sm750_primary; crtc->o_screen = 0; - crtc->v_screen = sm750_dev->pvMem; + crtc->v_screen = sm750_dev->vram; break; case sm750_simul_sec: output->paths = sm750_pnc; crtc->channel = sm750_secondary; crtc->o_screen = 0; - crtc->v_screen = sm750_dev->pvMem; + crtc->v_screen = sm750_dev->vram; break; case sm750_dual_normal: if (par->index == 0) { output->paths = sm750_panel; crtc->channel = sm750_primary; crtc->o_screen = 0; - crtc->v_screen = sm750_dev->pvMem; + crtc->v_screen = sm750_dev->vram; } else { output->paths = sm750_crt; crtc->channel = sm750_secondary; /* not consider of padding stuffs for o_screen,need fix */ crtc->o_screen = sm750_dev->vidmem_size >> 1; - crtc->v_screen = sm750_dev->pvMem + crtc->o_screen; + crtc->v_screen = sm750_dev->vram + crtc->o_screen; } break; case sm750_dual_swap: @@ -649,7 +649,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par) output->paths = sm750_panel; crtc->channel = sm750_secondary; crtc->o_screen = 0; - crtc->v_screen = sm750_dev->pvMem; + crtc->v_screen = sm750_dev->vram; } else { output->paths = sm750_crt; crtc->channel = sm750_primary; @@ -657,7 +657,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par) * need fix */ crtc->o_screen = sm750_dev->vidmem_size >> 1; - crtc->v_screen = sm750_dev->pvMem + crtc->o_screen; + crtc->v_screen = sm750_dev->vram + crtc->o_screen; } break; default: @@ -755,13 +755,13 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) * must be set after crtc member initialized */ crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024; - crtc->cursor.mmio = sm750_dev->pvReg + + crtc->cursor.mmio = sm750_dev->reg + 0x800f0 + (int)crtc->channel * 0x140; crtc->cursor.max_h = 64; crtc->cursor.max_w = 64; crtc->cursor.size = crtc->cursor.max_h * crtc->cursor.max_w * 2 / 8; - crtc->cursor.vstart = sm750_dev->pvMem + crtc->cursor.offset; + crtc->cursor.vstart = sm750_dev->vram + crtc->cursor.offset; memset_io(crtc->cursor.vstart, 0, crtc->cursor.size); if (!g_hwcursor) @@ -1028,7 +1028,7 @@ static int lynxfb_pci_probe(struct pci_dev *pdev, sm750_dev->mtrr.vram = arch_phys_wc_add(sm750_dev->vidmem_start, sm750_dev->vidmem_size); - memset_io(sm750_dev->pvMem, 0, sm750_dev->vidmem_size); + memset_io(sm750_dev->vram, 0, sm750_dev->vidmem_size); pci_set_drvdata(pdev, sm750_dev); @@ -1059,8 +1059,8 @@ static void lynxfb_pci_remove(struct pci_dev *pdev) sm750fb_framebuffer_release(sm750_dev); arch_phys_wc_del(sm750_dev->mtrr.vram); - iounmap(sm750_dev->pvReg); - iounmap(sm750_dev->pvMem); + iounmap(sm750_dev->reg); + iounmap(sm750_dev->vram); pci_release_region(pdev, 1); kfree(g_settings); } diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 9da154f1a..dadf5874a 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -97,8 +97,8 @@ struct sm750_dev { unsigned long vidreg_start; __u32 vidmem_size; __u32 vidreg_size; - void __iomem *pvReg; - unsigned char __iomem *pvMem; + void __iomem *reg; + unsigned char __iomem *vram; /* locks*/ spinlock_t slock; diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 59fb3a207..1b768be20 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -42,18 +42,18 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) } /* now map mmio and vidmem */ - sm750_dev->pvReg = + sm750_dev->reg = ioremap(sm750_dev->vidreg_start, sm750_dev->vidreg_size); - if (!sm750_dev->pvReg) { + if (!sm750_dev->reg) { dev_err(&pdev->dev, "mmio failed\n"); ret = -EFAULT; goto err_release_region; } - sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1; - sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1; + sm750_dev->accel.dpr_base = sm750_dev->reg + DE_BASE_ADDR_TYPE1; + sm750_dev->accel.dp_port_base = sm750_dev->reg + DE_PORT_ADDR_TYPE1; - mmio750 = sm750_dev->pvReg; + mmio750 = sm750_dev->reg; sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid); sm750_dev->vidmem_start = pci_resource_start(pdev, 0); @@ -66,9 +66,9 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) sm750_dev->vidmem_size = ddk750_get_vm_size(); /* reserve the vidmem space of smi adaptor */ - sm750_dev->pvMem = + sm750_dev->vram = ioremap_wc(sm750_dev->vidmem_start, sm750_dev->vidmem_size); - if (!sm750_dev->pvMem) { + if (!sm750_dev->vram) { dev_err(&pdev->dev, "Map video memory failed\n"); ret = -EFAULT; goto err_unmap_reg; @@ -77,7 +77,7 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) return 0; err_unmap_reg: - iounmap(sm750_dev->pvReg); + iounmap(sm750_dev->reg); err_release_region: pci_release_region(pdev, 1); return ret; -- 2.53.0