From: Greg KH <gregkh@linuxfoundation.org>
To: Cong Nguyen <congnt264@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: use nl80211_iftype instead of custom NDIS enum
Date: Tue, 7 Jul 2026 12:19:24 +0200 [thread overview]
Message-ID: <2026070705-cement-flyover-bfaa@gregkh> (raw)
In-Reply-To: <20260601161051.1832080-1-congnt264@gmail.com>
On Mon, Jun 01, 2026 at 11:10:51PM +0700, Cong Nguyen wrote:
> The driver defined its own enum ndis_802_11_network_infrastructure to
> represent the operating mode (STA/AP/IBSS) and translated nl80211 iftypes
> into it in cfg80211_rtw_change_iface(). The kernel already provides
> enum nl80211_iftype for this purpose, so use it directly and drop the
> redundant translation layer.
>
> Map the removed values as follows:
> Ndis802_11IBSS -> NL80211_IFTYPE_ADHOC
> Ndis802_11Infrastructure -> NL80211_IFTYPE_STATION
> Ndis802_11APMode -> NL80211_IFTYPE_AP
> Ndis802_11AutoUnknown -> NL80211_IFTYPE_UNSPECIFIED
>
> Compile-tested only.
>
> Signed-off-by: Cong Nguyen <congnt264@gmail.com>
> ---
> Changes in v2:
> - Replace the custom enum ndis_802_11_network_infrastructure with the
> standard enum nl80211_iftype and drop the translation layer, instead
> of just renaming the enum values to uppercase (Greg Kroah-Hartman).
>
> v1: https://lore.kernel.org/linux-staging/20260511134930.4086521-1-congnt264@gmail.com/
This doesn't apply anymore. Can you rebase it against my
staging-testing branch and resend?
thanks,
greg k-h
prev parent reply other threads:[~2026-07-07 10:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 16:10 [PATCH v2] staging: rtl8723bs: use nl80211_iftype instead of custom NDIS enum Cong Nguyen
2026-07-07 10:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070705-cement-flyover-bfaa@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=congnt264@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox