Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Moksh Panicker <mokshpanicker.7@gmail.com>
Cc: linux-staging@lists.linux.dev, dan.carpenter@linaro.org
Subject: Re: [PATCH v6 1/2] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature
Date: Tue, 7 Jul 2026 12:13:16 +0200	[thread overview]
Message-ID: <2026070711-trapezoid-attest-d8d8@gregkh> (raw)
In-Reply-To: <20260522125022.29700-2-mokshpanicker.7@gmail.com>

On Fri, May 22, 2026 at 12:50:21PM +0000, Moksh Panicker wrote:
> Reformat multi-line function signature to a single line to fix
> line length and coding style warnings from checkpatch.pl.
> 
> Also fix the missing brace/comment spacing in rtw_efuse_read_1_byte().
> 
> Note: CamelCase identifiers (Adapter, Address) are pre-existing
> in this function and not introduced by this patch.
> 
> Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 803a608b74fa..ab7486020b3f 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
>   * 09/23/2008	MHC		Copy from WMAC.
>   *
>   */
> -u8
> -rtw_efuse_read_1_byte(
> -struct adapter *Adapter,
> -u16		Address)
> +u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
>  {
>  	u8 Bytetemp = {0x00};
>  	u8 temp = {0x00};
> @@ -76,9 +73,9 @@ u16		Address)
>  				break;
>  		}
>  		return rtw_read8(Adapter, EFUSE_CTRL);
> -	} else
> +	} else {
>  		return 0xFF;
> -
> +	}
>  } /* rtw_efuse_read_1_byte */
>  
>  /*  11/16/2008 MH Read one byte from real Efuse. */
> -- 
> 2.34.1
> 

Does not apply to the tree :(

  reply	other threads:[~2026-07-07 10:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 12:50 [PATCH v6 0/2] staging: rtl8723bs: efuse signature cleanup Moksh Panicker
2026-05-22 12:50 ` [PATCH v6 1/2] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Moksh Panicker
2026-07-07 10:13   ` Greg KH [this message]
2026-05-22 12:50 ` [PATCH v6 2/2] staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature Moksh Panicker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070711-trapezoid-attest-d8d8@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mokshpanicker.7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox