Linux kernel staging patches
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Gabry <Gabry.256@proton.me>
Cc: "sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>,
	"teddy.wang@siliconmotion.com" <teddy.wang@siliconmotion.com>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: sm750fb: rename Bpp parameter to bpp
Date: Tue, 7 Jul 2026 11:06:10 +0200	[thread overview]
Message-ID: <2026070743-stubble-brick-6d56@gregkh> (raw)
In-Reply-To: <hpslpD7esY-xE37Tvrz0V8gD8YoZwdu6IlQ8LjUz5fY5mevEeDxM-dLC64t43G4mpVfHB_xCDUESoNFZ7ua9k7B_k2NrY2u-P6NYIJSuGt4=@proton.me>

On Thu, May 28, 2026 at 06:36:45PM +0000, Gabry wrote:
> The Linux kernel coding style prefers snake_case over CamelCase foridentifier names.
> 
> Rename the 'Bpp' parameter (bytes per pixel) of sm750_hw_fillrect()
> and sm750_hw_copyarea() to 'bpp' to comply with this standard. Update
> the function prototypes in sm750_accel.h and the corresponding
> kernel-doc descriptions accordingly.
> 
> This is a pure rename with no functional change, and addresses a
> checkpatch.pl warning:
> 
>   CHECK: Avoid CamelCase: <Bpp>
> 
> Signed-off-by: Gabriele Rizzo <gabry.256@proton.me>

Does not match up with your "From:" line :(

Also, this is the second version of this patch you sent out, what
changed from the first?

thanks,

greg k-h

      reply	other threads:[~2026-07-07  9:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28 18:36 [PATCH] staging: sm750fb: rename Bpp parameter to bpp Gabry
2026-07-07  9:06 ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070743-stubble-brick-6d56@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Gabry.256@proton.me \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox