From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jules Debbaut <julesdebbaut@icloud.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH 5/5] staging: rtl8723bs: fix lines exceeding 100 columns
Date: Tue, 7 Jul 2026 13:04:04 +0200 [thread overview]
Message-ID: <2026070752-movie-playgroup-0ebb@gregkh> (raw)
In-Reply-To: <20260602210407.4364-5-julesdebbaut@icloud.com>
On Tue, Jun 02, 2026 at 11:04:07PM +0200, Jules Debbaut wrote:
> Break long lines to fit within the 100-column limit. Extract
> local variables for repeated expressions in rtw_get_bcn_info()
> to shorten long rtw_get_ie() calls.
>
> Signed-off-by: Jules Debbaut <julesdebbaut@icloud.com>
> ---
> .../staging/rtl8723bs/core/rtw_ieee80211.c | 42 ++++++++++++-------
> 1 file changed, 28 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index 7cf014e25..8f08d7e74 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -237,7 +237,8 @@ int rtw_ies_remove_ie(u8 *ies, uint *ies_len, uint offset, u8 eid, u8 *oui, u8 o
> search_len = *ies_len - offset;
>
> while (1) {
> - target_ie = rtw_get_ie_ex(start, search_len, eid, oui, oui_len, NULL, &target_ielen);
> + target_ie = rtw_get_ie_ex(start, search_len, eid, oui,
> + oui_len, NULL, &target_ielen);
> if (target_ie && target_ielen) {
> u8 *remain_ies = target_ie + target_ielen;
> uint remain_len = search_len - (remain_ies - start);
> @@ -274,7 +275,8 @@ void rtw_set_supported_rate(u8 *supported_rates, uint mode)
> case WIRELESS_11_24N:
> case WIRELESS_11BG_24N:
> memcpy(supported_rates, WIFI_CCKRATES, IEEE80211_CCK_RATE_LEN);
> - memcpy(supported_rates + IEEE80211_CCK_RATE_LEN, WIFI_OFDMRATES, IEEE80211_NUM_OFDM_RATESLEN);
> + memcpy(supported_rates + IEEE80211_CCK_RATE_LEN,
> + WIFI_OFDMRATES, IEEE80211_NUM_OFDM_RATESLEN);
> break;
> }
> }
> @@ -301,7 +303,8 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv)
> ie += sz;
>
> /* beacon interval : 2bytes */
> - *(__le16 *)ie = cpu_to_le16((u16)pdev_network->configuration.beacon_period);/* BCN_INTERVAL; */
> + *(__le16 *)ie = cpu_to_le16((u16)pdev_network->configuration.beacon_period);
> + /* BCN_INTERVAL; */
Comment is now in the wrong place :(
prev parent reply other threads:[~2026-07-07 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 21:04 [PATCH 1/5] staging: rtl8723bs: remove unnecessary parentheses Jules Debbaut
2026-06-02 21:04 ` [PATCH 2/5] staging: rtl8723bs: add braces to else-if arms Jules Debbaut
2026-06-02 21:04 ` [PATCH 3/5] staging: rtl8723bs: fix alignment of continuation lines Jules Debbaut
2026-06-02 21:04 ` [PATCH 4/5] staging: rtl8723bs: rewrap long comments and remove dead code Jules Debbaut
2026-06-02 21:04 ` [PATCH 5/5] staging: rtl8723bs: fix lines exceeding 100 columns Jules Debbaut
2026-07-07 11:04 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070752-movie-playgroup-0ebb@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=julesdebbaut@icloud.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox