From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 7/9] staging: rtl8723bs: remove unused EEPROMVersion from struct hal_com_data
Date: Thu, 9 Jul 2026 21:15:14 +0300 [thread overview]
Message-ID: <20260709182627.16327-8-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260709182627.16327-1-nikolayof23@gmail.com>
A value is written to this field, but it is never used. Remove it, along
with the associated functions and macros, to simplify the code.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 ------------
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 1 -
drivers/staging/rtl8723bs/include/hal_data.h | 1 -
drivers/staging/rtl8723bs/include/hal_pg.h | 1 -
drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 2 --
5 files changed, 17 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 9c8bab512f2b..6b495e24e259 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1390,18 +1390,6 @@ void Hal_EfuseParseBTCoexistInfo_8723B(
hal_btcoex_SetSingleAntPath(padapter, pHalData->ant_path);
}
-void Hal_EfuseParseEEPROMVer_8723B(
- struct adapter *padapter, u8 *hwinfo, bool AutoLoadFail
-)
-{
- struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
-
- if (!AutoLoadFail)
- pHalData->EEPROMVersion = hwinfo[EEPROM_VERSION_8723B];
- else
- pHalData->EEPROMVersion = 1;
-}
-
void Hal_EfuseParsePackageType_8723B(
struct adapter *padapter, u8 *hwinfo, bool AutoLoadFail
)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 80119559664f..a08f7c78a921 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -1031,7 +1031,6 @@ static void _ReadEfuseInfo8723BS(struct adapter *padapter)
Hal_InitPGData(padapter, hwinfo);
Hal_EfuseParseIDCode(padapter, hwinfo);
- Hal_EfuseParseEEPROMVer_8723B(padapter, hwinfo, pEEPROM->bautoload_fail_flag);
Hal_EfuseParseMACAddr_8723BS(padapter, hwinfo, pEEPROM->bautoload_fail_flag);
diff --git a/drivers/staging/rtl8723bs/include/hal_data.h b/drivers/staging/rtl8723bs/include/hal_data.h
index 578cff14adc5..0a25688de041 100644
--- a/drivers/staging/rtl8723bs/include/hal_data.h
+++ b/drivers/staging/rtl8723bs/include/hal_data.h
@@ -161,7 +161,6 @@ struct hal_com_data {
u8 PackageType;
/* EEPROM setting. */
- u8 EEPROMVersion;
u8 EEPROMRegulatory;
u8 EEPROMThermalMeter;
u8 EEPROMBluetoothCoexist;
diff --git a/drivers/staging/rtl8723bs/include/hal_pg.h b/drivers/staging/rtl8723bs/include/hal_pg.h
index c0fca8fc7270..3362b349904d 100644
--- a/drivers/staging/rtl8723bs/include/hal_pg.h
+++ b/drivers/staging/rtl8723bs/include/hal_pg.h
@@ -38,7 +38,6 @@
#define EEPROM_RF_BOARD_OPTION_8723B 0xC1
#define EEPROM_RF_BT_SETTING_8723B 0xC3
-#define EEPROM_VERSION_8723B 0xC4
#define EEPROM_DEFAULT_DIFF 0XFE
/* RTL8723BS */
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
index 80cbf619e312..bb98f8a55a0b 100644
--- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
+++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
@@ -198,8 +198,6 @@ void Hal_EfuseParseTxPowerInfo_8723B(struct adapter *padapter, u8 *PROMContent,
bool AutoLoadFail);
void Hal_EfuseParseBTCoexistInfo_8723B(struct adapter *padapter, u8 *hwinfo,
bool AutoLoadFail);
-void Hal_EfuseParseEEPROMVer_8723B(struct adapter *padapter, u8 *hwinfo,
- bool AutoLoadFail);
void Hal_EfuseParseChnlPlan_8723B(struct adapter *padapter, u8 *hwinfo,
bool AutoLoadFail);
void Hal_EfuseParseXtal_8723B(struct adapter *padapter, u8 *hwinfo,
--
2.54.0
next prev parent reply other threads:[~2026-07-09 18:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 18:15 [PATCH 0/9] staging: rtl8723bs: remove some fields from the Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 1/9] staging: rtl8723bs: remove dead fields from struct hal_com_data Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 2/9] staging: rtl8723bs: remove unused 'PolarityCtl' " Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 3/9] staging: rtl8723bs: remove unused RegulatorMode " Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 4/9] staging: rtl8723bs: remove unused 'MultiFunc' " Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 5/9] staging: rtl8723bs: remove unused 'EEPROMCustomerID' from hal_com_data Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 6/9] staging: rtl8723bs: remove unused ForcedDataRate " Nikolay Kulikov
2026-07-09 18:15 ` Nikolay Kulikov [this message]
2026-07-09 18:15 ` [PATCH 8/9] staging: rtl8723bs: remove unused EEPROMBluetoothType " Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 9/9] staging: rtl8723bs: remove unused 'bTXPowerDataReadFromEEPORM' Nikolay Kulikov
2026-07-10 14:50 ` [PATCH 0/9] staging: rtl8723bs: remove some fields from the Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709182627.16327-8-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox