Linux kernel staging patches
 help / color / mirror / Atom feed
From: Hao-Qun Huang <alvinhuang0603@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Viresh Kumar <vireshk@kernel.org>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: hid: fix SET_REPORT return value
Date: Sat, 11 Jul 2026 15:29:36 +0800	[thread overview]
Message-ID: <20260711152936.191.alvinhuang0603@gmail.com> (raw)
In-Reply-To: <alCiZxAXbPDq3P4e@stanley.mountain>

Hi Dan,

Thanks, that makes sense now.  The point isn't just showing the code is
buggy, it's explaining why changing a years-old return value is safe, and
that belongs in the commit message rather than the thread.

I'll write that reasoning in next time (what checks the return, what
doesn't, and what could be affected) instead of leaving reviewers to ask.

Appreciate you taking the time to walk me through it.

Hao-Qun

      reply	other threads:[~2026-07-11  7:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-04  8:16 [PATCH] staging: greybus: hid: fix SET_REPORT return value Hao-Qun Huang
2026-07-09 10:52 ` Dan Carpenter
2026-07-09 18:06   ` Hao-Qun Huang
2026-07-09 18:50     ` Dan Carpenter
2026-07-10  4:40       ` Hao-Qun Huang
2026-07-10  7:42         ` Dan Carpenter
2026-07-11  7:29           ` Hao-Qun Huang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260711152936.191.alvinhuang0603@gmail.com \
    --to=alvinhuang0603@gmail.com \
    --cc=elder@kernel.org \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox