From: Jonathan Cameron <jic23@kernel.org>
To: Babanpreet Singh <bbnpreetsingh@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: frequency: remove incorrect kernel-doc markings in dds.h
Date: Mon, 13 Jul 2026 01:35:01 +0100 [thread overview]
Message-ID: <20260713013501.1912f3f3@jic23-huawei> (raw)
In-Reply-To: <20260712223004.7-1-bbnpreetsingh@gmail.com>
On Sun, 12 Jul 2026 22:30:04 +0000
Babanpreet Singh <bbnpreetsingh@gmail.com> wrote:
> The 13 comment blocks in dds.h noting which sysfs attribute each
> convenience macro creates are opened with the kernel-doc /** marker,
> but they are not kernel-doc: there is no identifier to document.
> Running kernel-doc on the file emits 103 warnings:
>
> $ scripts/kernel-doc -none drivers/staging/iio/frequency/dds.h
> Warning: drivers/staging/iio/frequency/dds.h:10 Cannot find
> identifier on line:
> * /sys/bus/iio/devices/.../out_altvoltageX_frequencyY
>
> The header is not scanned during normal builds (build-time kernel-doc
> checks cover .c files), so the warnings only show up when kernel-doc
> is invoked on the file directly.
>
> The comments have carried the /** marker since the file was introduced
> in commit 4851d97d87c8 ("Staging: IIO: dds.h convenience macros"). The
> attributes themselves are already documented in
> drivers/staging/iio/Documentation/sysfs-bus-iio-dds, so demote the
> comments to plain /* style rather than converting them into kernel-doc
> for the macros. No functional change.
>
> Assisted-by: Claude:claude-sonnet-5
> Signed-off-by: Babanpreet Singh <bbnpreetsingh@gmail.com>
Applied.
Thanks,
Jonathan
prev parent reply other threads:[~2026-07-13 0:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 22:30 [PATCH] staging: iio: frequency: remove incorrect kernel-doc markings in dds.h Babanpreet Singh
2026-07-13 0:35 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713013501.1912f3f3@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=bbnpreetsingh@gmail.com \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox