From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alfie Varghese <alfievarghese22@gmail.com>
Cc: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, dan.carpenter@linaro.org
Subject: Re: [PATCH v2] staging: greybus: uart: return tty_alloc_driver() errors
Date: Tue, 14 Jul 2026 09:39:19 +0200 [thread overview]
Message-ID: <2026071408-growing-thespian-b521@gregkh> (raw)
In-Reply-To: <CAHp0ZPPbdc+5PgFUDVgamt_Ds8xAY=K_GgH3abx3ucpndGepFg@mail.gmail.com>
On Tue, Jul 14, 2026 at 12:42:04PM +0530, Alfie Varghese wrote:
> gb_tty_init() maps any tty_alloc_driver() failure to -ENOMEM.
> tty_alloc_driver() currently always returns -ENOMEM on failure,
> so this does not change behavior in practice. However, returning
> PTR_ERR(gb_tty_driver) is more correct and consistent with kernel
> conventions, preserving any future error codes the function might
> return.
>
> Signed-off-by: Alfie Varghese <alfievarghese22@gmail.com>
> ---
> v2: updated commit message per Dan Carpenter's review to clarify
> that tty_alloc_driver() currently only returns -ENOMEM, making
> this a style fix rather than a behavioral change.
>
> drivers/staging/greybus/uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
> index 7d060b4cd33d..24b4dab069c3 100644
> --- a/drivers/staging/greybus/uart.c
> +++ b/drivers/staging/greybus/uart.c
> @@ -951,7 +951,7 @@ static int gb_tty_init(void)
> if (IS_ERR(gb_tty_driver)) {
> pr_err("Can not allocate tty driver\n");
> - retval = -ENOMEM;
> + retval = PTR_ERR(gb_tty_driver);
> goto fail_unregister_dev;
> }
Something went really wrong with this patch, it is corrupted :(
parent reply other threads:[~2026-07-14 7:39 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAHp0ZPPbdc+5PgFUDVgamt_Ds8xAY=K_GgH3abx3ucpndGepFg@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026071408-growing-thespian-b521@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alfievarghese22@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox