From: Greg KH <gregkh@linuxfoundation.org>
To: Arsenii Pashchenko <ulijg308@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper
Date: Wed, 15 Jul 2026 16:13:13 +0200 [thread overview]
Message-ID: <2026071546-commodore-mobility-c2bc@gregkh> (raw)
In-Reply-To: <20260713035156.144502-1-ulijg308@gmail.com>
On Mon, Jul 13, 2026 at 10:51:56AM +0700, Arsenii Pashchenko wrote:
> Collapse the static CamelCase helper function ReadChipVersion8723B()
> directly into the main rtl8723b_read_chip_version() function.
> This removes unnecessary code nesting and cleans up the CamelCase
> naming violation in a single atomic change.
>
> Signed-off-by: Arsenii Pashchenko <ulijg308@gmail.com>
> ---
> Changes in v3:
> - Merged the previous 2-patch series into a single patch as suggested
> by Nikolay. Completely removed the redundant helper instead of
> renaming it with '__' prefixes.
>
> Changes in v2:
> - Resent the series due to submission issues with v1 (no code changes).
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
The versioning goes below the --- line that is in the diff, don't create
a new one please.
Perhaps use a tool like `b4` to handle this all for you?
thanks,
greg k-h
prev parent reply other threads:[~2026-07-15 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 3:51 [PATCH v3] staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper Arsenii Pashchenko
2026-07-15 14:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026071546-commodore-mobility-c2bc@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ulijg308@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox