From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 9/9] staging: rtl8723bs: remove debug fields from hal_com_data
Date: Fri, 17 Jul 2026 21:52:08 +0300 [thread overview]
Message-ID: <20260717185407.56513-10-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260717185407.56513-1-nikolayof23@gmail.com>
These fields are never set. They are never read from, since
GetHalDefVar() function never receives the neccessary constants.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/hal/hal_com.c | 6 ------
drivers/staging/rtl8723bs/include/hal_data.h | 3 ---
2 files changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 80a775437751..2c856a2721b2 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -643,12 +643,6 @@ u8 GetHalDefVar(
case HAL_DEF_DBG_DM_FUNC:
*((u32 *)value) = hal_data->odmpriv.SupportAbility;
break;
- case HAL_DEF_DBG_DUMP_RXPKT:
- *((u8 *)value) = hal_data->bDumpRxPkt;
- break;
- case HAL_DEF_DBG_DUMP_TXPKT:
- *((u8 *)value) = hal_data->bDumpTxPkt;
- break;
case HAL_DEF_ANT_DETECT:
*((u8 *)value) = hal_data->AntDetection;
break;
diff --git a/drivers/staging/rtl8723bs/include/hal_data.h b/drivers/staging/rtl8723bs/include/hal_data.h
index 6c8664b59d2f..f67ca496902a 100644
--- a/drivers/staging/rtl8723bs/include/hal_data.h
+++ b/drivers/staging/rtl8723bs/include/hal_data.h
@@ -234,9 +234,6 @@ struct hal_com_data {
u8 u1ForcedIgiLb; /* forced IGI lower bound */
- u8 bDumpRxPkt;/* for debug */
- u8 bDumpTxPkt;/* for debug */
-
/* 2010/08/09 MH Add CU power down mode. */
bool pwrdown;
--
2.55.0
prev parent reply other threads:[~2026-07-17 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 18:51 [PATCH 0/9] staging: rtl8723bs: continued cleanup of struct Nikolay Kulikov
2026-07-17 18:52 ` [PATCH 1/9] staging: rtl8723bs: remove unused 'CCK_24G_Diff' from hal_com_data Nikolay Kulikov
2026-07-17 18:52 ` [PATCH 2/9] staging: rtl8723bs: remove unused array MCSTxPowerLevelOriginalOffset Nikolay Kulikov
2026-07-17 18:52 ` [PATCH 3/9] staging: rtl8723bs: remove unused 'bIQKInitialized ' from hal_com_data Nikolay Kulikov
2026-07-17 18:52 ` [PATCH 4/9] staging: rtl8723bs: remove unused 'bNeedIQK' from struct hal_com_data Nikolay Kulikov
2026-07-17 18:52 ` [PATCH 5/9] staging: rtl8723bs: hal: remove unused readings from the chip Nikolay Kulikov
2026-07-17 18:52 ` [PATCH 6/9] staging: rtl8723bs: remove unused 'UsbRxHighSpeedMode' from hal_com_data Nikolay Kulikov
2026-07-17 18:52 ` [PATCH 7/9] staging: rtl8723bs: remove unused spinlock 'SdioTxFIFOFreePageLock' Nikolay Kulikov
2026-07-17 18:52 ` [PATCH 8/9] staging: rtl8723bs: remove 'rf_chip' from struct hal_com_data Nikolay Kulikov
2026-07-17 18:52 ` Nikolay Kulikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717185407.56513-10-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox