Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Bohdan D. Marcus" <bohdandmarcus@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: rename MACREG macros to snake_case
Date: Fri, 17 Jul 2026 14:23:45 +0200	[thread overview]
Message-ID: <2026071727-amused-scandal-9bd5@gregkh> (raw)
In-Reply-To: <20260712132026.8836-1-bohdandmarcus@gmail.com>

On Sun, Jul 12, 2026 at 04:20:26PM +0300, Bohdan D. Marcus wrote:
> Fix checkpatch.pl warnings regarding CamelCase naming:
> CHECK: Avoid CamelCase: <_Read_MACREG>
> CHECK: Avoid CamelCase: <_Write_MACREG>
> 
> Rename _Read_MACREG and _Write_MACREG to read_macreg and
> write_macreg respectively to comply with the Linux kernel
> coding style.
> 
> Signed-off-by: Bohdan D. Marcus <bohdandmarcus@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c         | 4 ++--
>  drivers/staging/rtl8723bs/include/rtw_cmd.h      | 4 ++--
>  drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index b932670f5..f3b8a2bdf 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -11,8 +11,8 @@
>  #include <linux/delay.h>
>  
>  static struct _cmd_callback rtw_cmd_callback[] = {
> -	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
> -	{GEN_CMD_CODE(_Write_MACREG), NULL},
> +	{GEN_CMD_CODE(read_macreg), NULL}, /*0*/
> +	{GEN_CMD_CODE(write_macreg), NULL},

Why just these 2?  Why not make a patch series to fix up all of these,
one patch per name?

thanks,
greg k-h

      reply	other threads:[~2026-07-17 12:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-12 13:20 [PATCH] staging: rtl8723bs: rename MACREG macros to snake_case Bohdan D. Marcus
2026-07-17 12:23 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026071727-amused-scandal-9bd5@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bohdandmarcus@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox