From: ColtenOuO <jun930436@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: ColtenOuO <jun930436@gmail.com>, Hans de Goede <hansg@kernel.org>,
Michael Straube <straube.linux@gmail.com>,
Nikolay Kulikov <nikolayof23@gmail.com>,
Andrei Khomenkov <khomenkov@mailbox.org>,
Jennifer Guo <guojy.bj@gmail.com>, Minu Jin <s9430939@naver.com>,
Khasar Munkh-Erdene <02khasar@gmail.com>,
Mohammed Rizwan Kaniyate <mrizwank004@gmail.com>,
linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] staging: rtl8723bs: remove unnecessary else after break/return
Date: Tue, 21 Jul 2026 16:02:32 +0000 [thread overview]
Message-ID: <20260721160236.80963-1-jun930436@gmail.com> (raw)
checkpatch.pl flags an else clause following a branch that already
returns, in enqueue_reorder_recvframe(). Restructure the if/else-if/else
chain into sequential checks to remove the redundant else, with no
change in behavior.
Signed-off-by: ColtenOuO <jun930436@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 86c5e2c4e7dd..79bd56a5d6cd 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1783,14 +1783,12 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un
pnextrframe = (union recv_frame *)plist;
pnextattrib = &pnextrframe->u.hdr.attrib;
- if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num))
- plist = get_next(plist);
- else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
+ if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
/* Duplicate entry is found!! Do not insert current entry. */
- /* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */
return false;
- else
+ if (!SN_LESS(pnextattrib->seq_num, pattrib->seq_num))
break;
+ plist = get_next(plist);
}
/* spin_lock_irqsave(&ppending_recvframe_queue->lock, irql); */
--
2.43.0
next reply other threads:[~2026-07-21 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 16:02 ColtenOuO [this message]
2026-07-23 8:29 ` [PATCH] staging: rtl8723bs: remove unnecessary else after break/return Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721160236.80963-1-jun930436@gmail.com \
--to=jun930436@gmail.com \
--cc=02khasar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guojy.bj@gmail.com \
--cc=hansg@kernel.org \
--cc=khomenkov@mailbox.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mrizwank004@gmail.com \
--cc=nikolayof23@gmail.com \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox