From: Faisal Mukhtar <mukhtarfaisal03@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Eric Wu <kunjinkao.jp@gmail.com>,
Ayush Mukkanwar <ayushmukkanwar@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Faisal Mukhtar <mukhtarfaisal03@gmail.com>
Subject: [PATCH] drivers: staging: octeon: ethernet: removed unneeded parentheses
Date: Tue, 21 Jul 2026 21:04:17 +0500 [thread overview]
Message-ID: <20260721160417.242644-1-mukhtarfaisal03@gmail.com> (raw)
removed redundant inner parentheses around "interface < 2"
in 3 if statement instances within the file ethernet.c,
got the warning by running checkpatch.pl script on the file.
Signed-off-by: Faisal Mukhtar <mukhtarfaisal03@gmail.com>
---
drivers/staging/octeon/ethernet.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index f3fa221f452e..5083d9596972 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -247,7 +247,7 @@ static int cvm_oct_common_change_mtu(struct net_device *dev, int new_mtu)
dev->mtu = new_mtu;
- if ((interface < 2) &&
+ if (interface < 2 &&
(cvmx_helper_interface_get_mode(interface) !=
CVMX_HELPER_INTERFACE_MODE_SPI)) {
int index = INDEX(priv->port);
@@ -293,7 +293,7 @@ static void cvm_oct_common_set_multicast_list(struct net_device *dev)
struct octeon_ethernet *priv = netdev_priv(dev);
int interface = INTERFACE(priv->port);
- if ((interface < 2) &&
+ if (interface < 2 &&
(cvmx_helper_interface_get_mode(interface) !=
CVMX_HELPER_INTERFACE_MODE_SPI)) {
union cvmx_gmxx_rxx_adr_ctl control;
@@ -345,7 +345,7 @@ static int cvm_oct_set_mac_filter(struct net_device *dev)
union cvmx_gmxx_prtx_cfg gmx_cfg;
int interface = INTERFACE(priv->port);
- if ((interface < 2) &&
+ if (interface < 2 &&
(cvmx_helper_interface_get_mode(interface) !=
CVMX_HELPER_INTERFACE_MODE_SPI)) {
int i;
--
2.53.0
next reply other threads:[~2026-07-21 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 16:04 Faisal Mukhtar [this message]
2026-07-28 7:32 ` [PATCH] drivers: staging: octeon: ethernet: removed unneeded parentheses Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721160417.242644-1-mukhtarfaisal03@gmail.com \
--to=mukhtarfaisal03@gmail.com \
--cc=ayushmukkanwar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kunjinkao.jp@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox