From: Prajval Chaudhary <prajvalchaudhari733@gmail.com>
To: andriy.shevchenko@intel.com
Cc: hverkuil-cisco@xs4all.nl, mchehab@kernel.org,
sakari.ailios@linux.intel.com, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
Prajval Chaudhary <prajvalchaudhari733@gmail.com>
Subject: [PATCH v5 0/2] This series cleans up unused module parameters from the atomisp driver.
Date: Wed, 22 Jul 2026 11:16:13 +0530 [thread overview]
Message-ID: <20260722054615.21492-1-prajvalchaudhari733@gmail.com> (raw)
In-Reply-To: <YOUR_ANDY_EMAIL_MESSAGE_ID_HERE>
Patch 1 converts 'pad_w' and 'pad_h' module parameters into internal
driver defines (ATOMISP_PAD_W and ATOMISP_PAD_H).
Patch 2 removes 'dbg_level' and 'dbg_func' module parameters and updates
ia_css_debug_vdtrace() to filter trace logging to IA_CSS_DEBUG_WARNING
level or below to avoid potential dmesg log flooding.
Output Behavior Difference:
- Before: Trace logging depended on setting dbg_level via module
parameters. Higher values flooded dmesg with verbose low-level trace
messages.
- After: Trace logging is filtered at IA_CSS_DEBUG_WARNING via standard
vprintk facilities, avoiding dmesg flooding while maintaining
critical warnings.
Changes in v5:
- Converted pad_w/pad_h to ATOMISP_PAD_* macro defines instead of global
variables.
- Preserved blank line in ia_css_debug.h and sorted <linux/printk.h>
header inclusion.
- Added explanation of default levels and parameter options in commit
messages and cover letter.
Changes in v4:
- Fixed macro constant name in ia_css_debug_vdtrace() to
IA_CSS_DEBUG_WARNING.
- Guarded vprintk() with level check to prevent log flooding.
Prajval Chaudhary (2):
staging: media: atomisp: Remove pad_w and pad_h module parameters
staging: media: atomisp: Remove dbg_level and dbg_func module
parameters
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 8 ++++----
drivers/staging/media/atomisp/pci/atomisp_common.h | 6 ++----
.../media/atomisp/pci/atomisp_compat_css20.c | 12 +++---------
drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 4 ++--
drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 14 --------------
.../pci/runtime/debug/interface/ia_css_debug.h | 10 +++++-----
.../atomisp/pci/runtime/debug/src/ia_css_debug.c | 4 ++--
7 files changed, 18 insertions(+), 40 deletions(-)
--
2.34.1
next parent reply other threads:[~2026-07-22 5:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YOUR_ANDY_EMAIL_MESSAGE_ID_HERE>
2026-07-22 5:46 ` Prajval Chaudhary [this message]
2026-07-22 5:46 ` [PATCH v5 1/2] staging: media: atomisp: Remove pad_w and pad_h module parameters Prajval Chaudhary
2026-07-22 5:46 ` [PATCH v5 2/2] staging: media: atomisp: Remove dbg_level and dbg_func " Prajval Chaudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722054615.21492-1-prajvalchaudhari733@gmail.com \
--to=prajvalchaudhari733@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailios@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox