From: Tomas Chimenti <tach.365@gmail.com>
To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, hansg@kernel.org,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
andy@kernel.org, gregkh@linuxfoundation.org
Cc: ~lkcamp/patches@lists.sr.ht, koike@igalia.com,
Tomas Chimenti <tach.365@gmail.com>
Subject: [PATCH] media: atomisp: Remove useless return statement
Date: Thu, 23 Jul 2026 12:21:46 -0300 [thread overview]
Message-ID: <20260723152146.86978-1-tach.365@gmail.com> (raw)
Fix checkpatch error
"WARNING: void function return statements are not generally useful"
Signed-off-by: Tomas Chimenti <tach.365@gmail.com>
---
Hello
This is my first patch, any feedback would be very welcome. Thanks
---
.../pci/runtime/inputfifo/src/inputfifo.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c b/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c
index 8e1efeb6372c..f0dcd839e33b 100644
--- a/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c
+++ b/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c
@@ -88,7 +88,6 @@ _sh_css_fifo_snd(unsigned int token)
while (!can_event_send_token(STR2MIPI_EVENT_ID))
udelay(1);
event_send_token(STR2MIPI_EVENT_ID, token);
- return;
}
static void inputfifo_send_data_a(
@@ -98,7 +97,6 @@ static void inputfifo_send_data_a(
unsigned int token = (1 << HIVE_STR_TO_MIPI_VALID_A_BIT) |
(data << HIVE_STR_TO_MIPI_DATA_A_LSB);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_data_b(
@@ -108,7 +106,6 @@ static void inputfifo_send_data_b(
unsigned int token = (1 << HIVE_STR_TO_MIPI_VALID_B_BIT) |
(data << _HIVE_STR_TO_MIPI_DATA_B_LSB);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_data(
@@ -121,7 +118,6 @@ static void inputfifo_send_data(
(a << HIVE_STR_TO_MIPI_DATA_A_LSB) |
(b << _HIVE_STR_TO_MIPI_DATA_B_LSB));
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_sol(void)
@@ -131,7 +127,6 @@ static void inputfifo_send_sol(void)
1 << HIVE_STR_TO_MIPI_SOL_BIT);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_eol(void)
@@ -140,7 +135,6 @@ static void inputfifo_send_eol(void)
hrt_data token = inputfifo_wrap_marker(
1 << HIVE_STR_TO_MIPI_EOL_BIT);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_sof(void)
@@ -150,7 +144,6 @@ static void inputfifo_send_sof(void)
1 << HIVE_STR_TO_MIPI_SOF_BIT);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_eof(void)
@@ -159,7 +152,6 @@ static void inputfifo_send_eof(void)
hrt_data token = inputfifo_wrap_marker(
1 << HIVE_STR_TO_MIPI_EOF_BIT);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_ch_id_and_fmt_type(
@@ -177,7 +169,6 @@ static void inputfifo_send_ch_id_and_fmt_type(
*/
token = inputfifo_wrap_marker(0);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_empty_token(void)
@@ -186,7 +177,6 @@ static void inputfifo_send_empty_token(void)
hrt_data token = inputfifo_wrap_marker(0);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_start_frame(
@@ -196,7 +186,6 @@ static void inputfifo_start_frame(
{
inputfifo_send_ch_id_and_fmt_type(ch_id, fmt_type);
inputfifo_send_sof();
- return;
}
static void inputfifo_end_frame(
@@ -207,7 +196,6 @@ static void inputfifo_end_frame(
for (i = 0; i < marker_cycles; i++)
inputfifo_send_empty_token();
inputfifo_send_eof();
- return;
}
static void inputfifo_send_line2(
@@ -297,7 +285,6 @@ static void inputfifo_send_line2(
for (i = 0; i < hblank_cycles; i++)
inputfifo_send_empty_token();
inputfifo_send_eol();
- return;
}
static void
@@ -377,7 +364,6 @@ static void inputfifo_send_frame(
}
}
inputfifo_end_frame(marker_cycles);
- return;
}
static enum inputfifo_mipi_data_type inputfifo_determine_type(
@@ -453,7 +439,6 @@ void ia_css_inputfifo_start_frame(
s2mi->streaming = true;
inputfifo_start_frame(ch_id, s2mi->fmt_type);
- return;
}
void ia_css_inputfifo_send_line(
@@ -516,5 +501,4 @@ void ia_css_inputfifo_end_frame(
inputfifo_end_frame(s2mi->marker_cycles);
s2mi->streaming = false;
- return;
}
--
2.39.5
reply other threads:[~2026-07-23 15:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723152146.86978-1-tach.365@gmail.com \
--to=tach.365@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=koike@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox