Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dang Vu Duc Hien <dvdh12707@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove unnecessary braces
Date: Tue, 28 Jul 2026 09:36:45 +0200	[thread overview]
Message-ID: <2026072834-shrug-winner-1fb0@gregkh> (raw)
In-Reply-To: <20260726092319.529566-1-dvdh12707@gmail.com>

On Sun, Jul 26, 2026 at 04:23:19PM +0700, Dang Vu Duc Hien wrote:
> Fix the checkpatch.pl warning:
> "WARNING: braces {} are not necessary for single statement blocks"
> in rtw_wlan_util.c.
> 
> The if-statement only contains one line of code. Remove the redundant
> pair of braces to comply with the kernel coding style.
> 
> Signed-off-by: Dang Vu Duc Hien <dvdh12707@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> index a4de53872..f107304eb 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> @@ -256,9 +256,8 @@ inline void rtw_set_oper_ch(struct adapter *adapter, u8 ch)
>  {
>  	struct dvobj_priv *dvobj = adapter_to_dvobj(adapter);
>  
> -	if (dvobj->oper_channel != ch) {
> +	if (dvobj->oper_channel != ch)
>  		dvobj->on_oper_ch_time = jiffies;
> -	}
>  
>  	dvobj->oper_channel = ch;
>  }
> -- 
> 2.54.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did not apply to any known trees that Greg is in control
  of.  Possibly this is because you made it against Linus's tree, not
  the linux-next tree, which is where all of the development for the
  next version of the kernel is at.  Please refresh your patch against
  the linux-next tree, or even better yet, the development tree
  specified in the MAINTAINERS file for the subsystem you are submitting
  a patch for, and resend it.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

  reply	other threads:[~2026-07-28  7:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-26  9:23 [PATCH] staging: rtl8723bs: remove unnecessary braces Dang Vu Duc Hien
2026-07-28  7:36 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-07-12 15:34 Arsenii Pashchenko
2026-07-01 14:57 Aditya Tipre
2026-07-07 11:33 ` Greg Kroah-Hartman
2026-05-07 17:52 Shivam Gupta
2026-05-10 17:31 ` Nikolay Kulikov
2026-03-04 17:19 Zeynep Dicle
2026-03-05 22:33 ` Ethan Tidmore
2026-01-28 15:44 Louis Lesniak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026072834-shrug-winner-1fb0@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dvdh12707@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox