From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Faisal Mukhtar <mukhtarfaisal03@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vme_user: Remove unnecessary parentheses
Date: Tue, 28 Jul 2026 09:18:09 +0200 [thread overview]
Message-ID: <2026072836-blob-morality-4337@gregkh> (raw)
In-Reply-To: <20260723152417.475323-1-mukhtarfaisal03@gmail.com>
On Thu, Jul 23, 2026 at 08:24:17PM +0500, Faisal Mukhtar wrote:
> Fix style problems found by checkpatch.pl,
> which are the unneeded parentheses inside if
> statements in vme.c.
>
> Signed-off-by: Faisal Mukhtar <mukhtarfaisal03@gmail.com>
> ---
> drivers/staging/vme_user/vme.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
> index b5c66b66ce32..68b5c4613724 100644
> --- a/drivers/staging/vme_user/vme.c
> +++ b/drivers/staging/vme_user/vme.c
> @@ -1210,9 +1210,9 @@ void vme_bus_error_handler(struct vme_bridge *bridge,
> u32 aspace = vme_get_aspace(am);
>
> list_for_each_entry(handler, &bridge->vme_error_handlers, list) {
> - if ((aspace == handler->aspace) &&
> - (address >= handler->start) &&
> - (address < handler->end)) {
> + if (aspace == handler->aspace &&
> + address >= handler->start &&
> + address < handler->end) {
Please see the archives for why this patch just makes things harder to
understand. checkpatch should have not warned you about this, always be
sure to use the latest version.
thanks,
greg k-h
prev parent reply other threads:[~2026-07-28 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 15:24 [PATCH] staging: vme_user: Remove unnecessary parentheses Faisal Mukhtar
2026-07-28 7:18 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026072836-blob-morality-4337@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mukhtarfaisal03@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox