Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shivesh <chanelshivesh@gmail.com>
Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
	elder@kernel.org, greybus-dev@lists.linaro.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] greybus: audio_manager: fix sysfs_emit newline and const warnings
Date: Tue, 28 Jul 2026 09:15:28 +0200	[thread overview]
Message-ID: <2026072857-moody-twelve-33e4@gregkh> (raw)
In-Reply-To: <6a64be09.c4d3d80a.348a49.42e7@mx.google.com>

On Sat, Jul 25, 2026 at 06:45:45AM -0700, Shivesh wrote:
> >From 5e0bcb4920bcb9e0ef6c03a91730fe45f643f3a4 Mon Sep 17 00:00:00 2001
> From: Shivesh <shivesh@example.com>
> Date: Sat, 25 Jul 2026 13:44:36 +0000
> Subject: [PATCH] greybus: audio_manager: fix sysfs_emit newline and const
>  warnings
> 
> Add terminating newlines to sysfs_emit() format strings as required
> by the kernel sysfs convention. Also make envp[] array const to fix
> checkpatch warning about char* array declaration.
> 
> Signed-off-by: Shivesh <chanelshivesh@gmail.com>
> Signed-off-by: Shivesh <shivesh@example.com>

Something went really wrong here, why sign off on this twice with
different email addresses?

Also, look in the archives for all the times that this same change has
been rejected.

thanks,

greg k-h

      reply	other threads:[~2026-07-28  7:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-25 13:45 [PATCH] greybus: audio_manager: fix sysfs_emit newline and const warnings Shivesh
2026-07-28  7:15 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026072857-moody-twelve-33e4@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=chanelshivesh@gmail.com \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mgreer@animalcreek.com \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox