From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Connor Sample <tabulatejarl8@gmail.com>
Cc: linux-staging@lists.linux.dev,
Ethan Tidmore <ethantidmore06@gmail.com>,
Nikolay Kulikov <nikolayof23@gmail.com>,
Dan Carpenter <error27@gmail.com>,
Luka Gejak <luka.gejak@linux.dev>,
Khushal Chitturi <khushalchitturi@gmail.com>,
Hungyu Lin <dennylin0707@gmail.com>,
Samasth Norway Ananda <samasth.norway.ananda@oracle.com>,
Adrish Bora <adrishbora@gmail.com>,
Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
Subject: Re: [PATCH] staging: rtl8723bs: os_intfs: replace msleep with usleep_range
Date: Thu, 30 Jul 2026 09:37:31 +0200 [thread overview]
Message-ID: <2026073013-tattling-herself-8f46@gregkh> (raw)
In-Reply-To: <20260729052040.249972-1-tabulatejarl8@gmail.com>
On Wed, Jul 29, 2026 at 01:20:38AM -0400, Connor Sample wrote:
> checkpatch.pl warns that `msleep()` of durations <20ms may sleep for up
> to 20ms. As per `Documentation/timers/delay_sleep_functions.rst`,
> `usleep_range()` should be used whenever the accuracy of `msleep()` is
> not sufficient in order to avoid jiffy rounding.
>
> Replaced `msleep(10)` with `usleep_range(10000, 11000)` and replaced a
> 1ms polling loop (`msleep(1)`) with `usleep_range(1000, 2000)`. This
> should provide improved scheduling tolerances without changing the
> minimum delay expectation for the hardware.
Please see the many places in the mailing list archives where we have
rejected this same patch :)
prev parent reply other threads:[~2026-07-30 7:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 5:20 [PATCH] staging: rtl8723bs: os_intfs: replace msleep with usleep_range Connor Sample
2026-07-30 7:37 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026073013-tattling-herself-8f46@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=adrishbora@gmail.com \
--cc=dennylin0707@gmail.com \
--cc=error27@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=khushalchitturi@gmail.com \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
--cc=nikolayof23@gmail.com \
--cc=samasth.norway.ananda@oracle.com \
--cc=shyamsunderreddypadira@gmail.com \
--cc=tabulatejarl8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox