Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Nguyễn Công" <congnt264@gmail.com>
Cc: Rui Miguel Silva <rmfrfs@gmail.com>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: light: fix leak of cdev->name
Date: Thu, 30 Jul 2026 13:06:54 +0200	[thread overview]
Message-ID: <2026073028-impaired-acuteness-e80a@gregkh> (raw)
In-Reply-To: <CAJpJ=GtHycfZncrux5chZLF-s97DiTjm-Ps_cjopamT0OPwtkw@mail.gmail.com>

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Jul 30, 2026 at 05:57:15PM +0700, Nguyễn Công wrote:
> Hi Greg,
> I used an LLM-based agent (Claude) to flag allocations that aren't freed
> on error paths, then I verified this one by hand: I traced every place
> cdev->name (from kasprintf()) is freed and found that
> __gb_lights_led_unregister() misses it on the config-failure and flash
> channel teardown paths. No static-analysis tool was used - just the
> agent to surface the candidate plus manual review.

Then please properly document this as required.

thanks,

greg k-h

      reply	other threads:[~2026-07-30 11:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-26 11:00 [PATCH] staging: greybus: light: fix leak of cdev->name Cong Nguyen
2026-07-28  7:17 ` Greg Kroah-Hartman
2026-07-30 10:57   ` Nguyễn Công
2026-07-30 11:06     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026073028-impaired-acuteness-e80a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=congnt264@gmail.com \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=rmfrfs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox