From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ivy Lopez <skunkolee@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: use guard(mutex) in ips_enter()
Date: Fri, 31 Jul 2026 07:19:58 +0200 [thread overview]
Message-ID: <2026073127-unicorn-supervise-165a@gregkh> (raw)
In-Reply-To: <20260730231714.81977-1-skunkolee@gmail.com>
On Thu, Jul 30, 2026 at 05:17:13PM -0600, Ivy Lopez wrote:
> Replace manual mutex_lock()/mutex_unlock() in ips_enter() with
> guard(mutex) from linux/cleanup.h. This is a single-exit function
> so the conversion is a direct drop-in and removes the need to
> manually balance the unlock.
Yes, but as stated before, that's great for new code, but for existing
code that is not broken, you should just leave it alone and not convert
to using guard().
thanks,
greg k-h
prev parent reply other threads:[~2026-07-31 5:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 23:17 [PATCH] staging: rtl8723bs: use guard(mutex) in ips_enter() Ivy Lopez
2026-07-30 23:17 ` [PATCH] staging: rtl8723bs: use kfree_sensitive() for key material in rtw_set_key() Ivy Lopez
2026-07-30 23:20 ` Ivy Lopez
2026-07-31 5:19 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026073127-unicorn-supervise-165a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=skunkolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox