From: Noah Techoueyres <noahtechoueyres@gmail.com>
To: dtwlin@gmail.com, johan@kernel.org, elder@kernel.org,
gregkh@linuxfoundation.org
Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
Noah Techoueyres <noahtechoueyres@gmail.com>
Subject: [PATCH] staging: greybus: uart: Add comments for lock definitions
Date: Sun, 2 Aug 2026 22:18:57 -0400 [thread overview]
Message-ID: <20260803021857.989-1-noahtechoueyres@gmail.com> (raw)
Add comments to spinlock and mutex fields explaining what they
protect, as required by kernel coding style for lock definitions.
Signed-off-by: Noah Techoueyres <noahtechoueyres@gmail.com>
---
drivers/staging/greybus/uart.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 7d060b4cd33d..46f38428c5cc 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -50,12 +50,12 @@ struct gb_tty {
unsigned int minor;
unsigned char clocal;
bool disconnected;
- spinlock_t read_lock;
- spinlock_t write_lock;
+ spinlock_t read_lock; /* Protects read operations */
+ spinlock_t write_lock; /* Protects write operations */
struct async_icount iocount;
struct async_icount oldcount;
wait_queue_head_t wioctl;
- struct mutex mutex;
+ struct mutex mutex; /* Protects port configuration */
u8 ctrlin; /* input control lines */
u8 ctrlout; /* output control lines */
struct gb_uart_set_line_coding_request line_coding;
--
2.43.0
reply other threads:[~2026-08-03 2:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803021857.989-1-noahtechoueyres@gmail.com \
--to=noahtechoueyres@gmail.com \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox