From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev,
Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 4/4] staging: media: ipu7: remove unnecessary "#pragma pack()" directives
Date: Wed, 05 Aug 2026 21:23:08 +0300 [thread overview]
Message-ID: <20260805-ipu7_abi-v1-4-46d420cef267@gmail.com> (raw)
In-Reply-To: <20260805-ipu7_abi-v1-0-46d420cef267@gmail.com>
After the removeal of unused structures, these directives have no effect
and can be removed.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h | 6 ------
drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h | 20 --------------------
2 files changed, 26 deletions(-)
diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h b/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h
index b85dcc519a31..40c7843ad7a7 100644
--- a/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h
+++ b/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h
@@ -29,9 +29,6 @@ struct ia_gofo_msg_version_list {
#pragma pack(pop)
-#pragma pack(push, 1)
-#pragma pack(pop)
-
#define IA_GOFO_MSG_ERR_MAX_DETAILS (4U)
#define IA_GOFO_MSG_ERR_OK (0U)
#define IA_GOFO_MSG_ERR_GROUP_UNSPECIFIED (0U)
@@ -49,14 +46,11 @@ struct ia_gofo_msg_err {
#define IA_GOFO_MSG_ERR_GROUP_RESERVED IA_GOFO_MSG_ERR_GROUP_UNSPECIFIED
#define IA_GOFO_MSG_ERR_GROUP_GENERAL 1
-#pragma pack(push, 1)
#define IA_GOFO_MSG_TYPE_RESERVED 0
#define IA_GOFO_MSG_TYPE_INDIRECT 1
#define IA_GOFO_MSG_TYPE_LOG 2
#define IA_GOFO_MSG_TYPE_GENERAL_ERR 3
-#pragma pack(pop)
-
#pragma pack(push, 1)
enum ia_gofo_msg_link_streaming_mode {
IA_GOFO_MSG_LINK_STREAMING_MODE_SOFF = 0,
diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h b/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h
index b2e6bd9159f2..01f4ce857238 100644
--- a/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h
+++ b/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h
@@ -8,8 +8,6 @@
#include "ipu7_fw_common_abi.h"
-#pragma pack(push, 1)
-
#define IPU_MSG_NODE_MAX_DEVICES (128U)
#define DEB_NUM_UINT32 (IPU_MSG_NODE_MAX_DEVICES / (sizeof(u32) * 8U))
@@ -21,28 +19,10 @@ typedef u32 ipu7_msg_deb_t[DEB_NUM_UINT32];
typedef u32 ipu7_msg_rbm_t[RBM_NUM_UINT32];
-#pragma pack(pop)
-
-#pragma pack(push, 1)
-
#define IPU_MSG_LINK_FOREIGN_KEY_NONE (65535U)
#define IPU_MSG_LINK_PBK_ID_DONT_CARE (255U)
#define IPU_MSG_LINK_PBK_SLOT_ID_DONT_CARE (255U)
-#pragma pack(pop)
-
-#pragma pack(push, 1)
-#pragma pack(pop)
-
-#pragma pack(push, 1)
-#pragma pack(pop)
-
-#pragma pack(push, 1)
-
-#pragma pack(pop)
-
-#pragma pack(push, 1)
-#pragma pack(pop)
#define FWPS_MSG_ABI_MAX_INPUT_QUEUES (60U)
#define FWPS_MSG_ABI_MAX_OUTPUT_QUEUES (2U)
--
2.55.0
next prev parent reply other threads:[~2026-08-05 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 18:23 [PATCH 0/4] staging: media: ipu7: abi headers cleanup Nikolay Kulikov
2026-08-05 18:23 ` [PATCH 1/4] staging: media: ipu7: remove unused structures from abi/ headers Nikolay Kulikov
2026-08-05 18:23 ` [PATCH 2/4] staging: media: ipu7: remove unused abi/ macros Nikolay Kulikov
2026-08-05 18:23 ` [PATCH 3/4] staging: media: ipu7: remove unused abi enums Nikolay Kulikov
2026-08-05 18:23 ` Nikolay Kulikov [this message]
2026-09-04 8:05 ` [PATCH 0/4] staging: media: ipu7: abi headers cleanup Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805-ipu7_abi-v1-4-46d420cef267@gmail.com \
--to=nikolayof23@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox