From: Greg KH <gregkh@linuxfoundation.org>
To: イムティヤズ <reza1234khan1234@gmail.com>
Cc: linux-staging@lists.linux.dev, stable@kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix OOB read in rtw_restruct_wmm_ie()
Date: Wed, 5 Aug 2026 13:23:31 +0200 [thread overview]
Message-ID: <2026080505-saturday-driven-b0d8@gregkh> (raw)
In-Reply-To: <20260805103344.172115-1-reza1234khan1234@gmail.com>
On Wed, Aug 05, 2026 at 04:33:44PM +0600, イムティヤズ wrote:
> The IE parsing loop in rtw_restruct_wmm_ie() reads in_ie[i + 1] (the
> length byte) and, when a vendor specific WMM IE is found, copies 9
> bytes starting from in_ie[i], while only guarding the reads with
> i + 5 < in_len. When the IE section of a beacon ends with a single
> byte remaining, in_ie[i + 1] is read one byte past the end of the
> buffer. A crafted IE with a short length field can likewise make the
> 9-byte copy read past the end of the buffer.
>
> Validate that the 2-byte IE header and the declared payload length
> are fully in bounds, and require the WMM IE to be at least 9 bytes
> long so that the copy stays within the buffer.
>
> Cc: stable@kernel.org
> Signed-off-by: イムティヤズ <reza1234khan1234@gmail.com>
> Assisted-by: opencode:auto/best-free
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
As per the recent announcement, you need to prove how you tested this on
real hardware and all still works properly.
thanks,
greg k-h
next prev parent reply other threads:[~2026-08-05 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 10:33 [PATCH] staging: rtl8723bs: fix OOB read in rtw_restruct_wmm_ie() イムティヤズ
2026-08-05 10:54 ` イムティヤズ
2026-08-05 11:10 ` イムティヤズ
2026-08-05 11:23 ` Greg KH [this message]
2026-08-05 18:47 ` イムティヤズ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026080505-saturday-driven-b0d8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=reza1234khan1234@gmail.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox