From: Batu Ada Tutkun <batuadatutkun@gmail.com>
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Batu Ada Tutkun <batuadatutkun@gmail.com>
Subject: [PATCH] staging: greybus: loopback: remove unused includes
Date: Wed, 12 Aug 2026 21:03:54 +0300 [thread overview]
Message-ID: <20260812180354.1968-1-batuadatutkun@gmail.com> (raw)
linux/random.h, linux/sizes.h, linux/cdev.h, linux/fs.h, and
linux/workqueue.h are not used anywhere in this file; none of their
symbols appear in the source, and none are needed transitively either
(debugfs helpers come from linux/debugfs.h, the async worker uses
kthread_run()/kthread_stop() rather than the workqueue API).
Verified by removing the five includes and rebuilding
drivers/staging/greybus out-of-tree with W=1: no new warnings or
errors, and checkpatch.pl reports the same warning/check count before
and after.
Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Batu Ada Tutkun <batuadatutkun@gmail.com>
---
drivers/staging/greybus/loopback.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index ea57b1f5d156..1169cfcd28c6 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -14,15 +14,10 @@
#include <linux/slab.h>
#include <linux/kthread.h>
#include <linux/delay.h>
-#include <linux/random.h>
-#include <linux/sizes.h>
-#include <linux/cdev.h>
-#include <linux/fs.h>
#include <linux/kfifo.h>
#include <linux/debugfs.h>
#include <linux/list_sort.h>
#include <linux/spinlock.h>
-#include <linux/workqueue.h>
#include <linux/atomic.h>
#include <linux/pm_runtime.h>
#include <linux/greybus.h>
--
2.53.0
reply other threads:[~2026-08-12 18:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812180354.1968-1-batuadatutkun@gmail.com \
--to=batuadatutkun@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox