From: "André Moreira" <andrem.33333@gmail.com>
To: pure.logic@nexus-software.ie
Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
"André Moreira" <andrem.33333@gmail.com>
Subject: [PATCH] staging: greybus: remove unused loopback macro
Date: Wed, 12 Aug 2026 15:38:32 -0300 [thread overview]
Message-ID: <20260812183833.39666-1-andrem.33333@gmail.com> (raw)
The gb_loopback_attr macro is no longer used in the Greybus
loopback driver. Remove the unused macro to avoid keeping dead
code in the driver.
Signed-off-by: André Moreira <andrem.33333@gmail.com>
---
drivers/staging/greybus/loopback.c | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index ea57b1f5d156..2a623fc2e99b 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -167,32 +167,6 @@ static DEVICE_ATTR_RO(name##_avg)
gb_loopback_ro_stats_attr(field, max, u); \
gb_loopback_ro_avg_attr(field)
-#define gb_loopback_attr(field, type) \
-static ssize_t field##_show(struct device *dev, \
- struct device_attribute *attr, \
- char *buf) \
-{ \
- struct gb_loopback *gb = dev_get_drvdata(dev); \
- return sysfs_emit(buf, "%" #type "\n", gb->field); \
-} \
-static ssize_t field##_store(struct device *dev, \
- struct device_attribute *attr, \
- const char *buf, \
- size_t len) \
-{ \
- int ret; \
- struct gb_loopback *gb = dev_get_drvdata(dev); \
- mutex_lock(&gb->mutex); \
- ret = sscanf(buf, "%"#type, &gb->field); \
- if (ret != 1) \
- len = -EINVAL; \
- else \
- gb_loopback_check_attr(gb, bundle); \
- mutex_unlock(&gb->mutex); \
- return len; \
-} \
-static DEVICE_ATTR_RW(field)
-
#define gb_dev_loopback_ro_attr(field) \
static ssize_t field##_show(struct device *dev, \
struct device_attribute *attr, \
--
2.43.0
reply other threads:[~2026-08-12 18:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812183833.39666-1-andrem.33333@gmail.com \
--to=andrem.33333@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox